Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade rollup to version 1.0.0 #551

Closed
wants to merge 1 commit into from
Closed

Conversation

depfu[bot]
Copy link
Contributor

@depfu depfu bot commented Dec 29, 2018

Here is everything you need to know about this upgrade. Please take a good look at what changed and the test results before merging this pull request.

What changed?

✳️ rollup (^0.68.1 → ^1.0.0) · Repo · Changelog

Release Notes

1.0.0

2018-12-28

Breaking Changes

  • Several (mostly deprecated) options have been removed or renamed (#2293, #2409):
    • banner -> output.banner
    • dest -> output.file
    • entry -> input
    • experimentalCodeSplitting -> now always active
    • experimentalDynamicImport -> now always active
    • experimentalPreserveModules -> preserveModules
    • exports -> output.exports
    • extend -> output.extend
    • footer -> output.footer
    • format -> output.format
    • freeze -> output.freeze
    • globals -> output.globals
    • indent -> output.indent
    • interop -> output.interop
    • intro -> output.intro
    • load -> use plugin API
    • moduleName -> output.name
    • name -> output.name
    • noConflict -> output.noConflict
    • output.moduleId -> output.amd.id
    • outro -> output.outro
    • paths -> output.paths
    • preferConst -> output.preferConst
    • pureExternalModules -> treeshake.pureExternalModules
    • resolveExternal -> use plugin API
    • resolveId -> use plugin API
    • sourcemap -> output.sourcemap
    • sourceMap -> output.sourcemap
    • sourceMapFile -> output.sourcemapFile
    • strict -> output.strict
    • targets -> use output as an array
    • transform -> use plugin API
    • useStrict -> output.strict
  • In general, output options can no longer be used as input options (#2409)
  • bundle.generate and bundle.write now return a new format (#2293)
  • Several plugin hooks have become deprecated and will display warnings when used (#2409):
    • transformBundle
    • transformChunk
    • ongenerate
    • onwrite
  • Plugin transform dependencies are deprecated in favour of the watchChange plugin hook (#2409)
  • Accessing this.watcher in plugin hooks is deprecated in favour of the watchChange plugin hook (#2409)
  • Using dynamic import statements will by default create a new chunk unless inlineDynamicImports is used (#2293)
  • Rollup now uses acorn@6 which means that acorn plugins must be compatible with this version; acorn is now external for non-browser builds to make plugins work (#2293)

Features

  • The --dir ClI option can now be aliased as -d (#2293)
  • The --input option now supports named entry points via = (#2293)

Bug Fixes

  • Both the --input option as well as the default CLI option now support named inputs (#2293)

Pull Requests

Commits

See the full diff on Github. The new version differs by 5 commits:


Depfu Status

Depfu will automatically keep this PR conflict-free, as long as you don't add any commits to this branch yourself. You can also trigger a rebase manually by commenting with @depfu rebase.

All Depfu comment commands
@​depfu rebase
Rebases against your default branch and redoes this update
@​depfu merge
Merges this PR once your tests are passing and conflicts are resolved
@​depfu reopen
Restores the branch and reopens this PR (if it's closed)
@​depfu pause
Ignores all future updates for this dependency and closes this PR
@​depfu pause [minor|major]
Ignores all future minor/major updates for this dependency and closes this PR
@​depfu resume
Future versions of this dependency will create PRs again (leaves this PR as is)

@depfu depfu bot added the depfu label Dec 29, 2018
@papandreou
Copy link
Member

One test timed out after 2 seconds:

29 12 2018 22:02:55.472:INFO [IE 11.0.0 (Windows 7.0.0)]: Connected on socket 9FgoI0RBBtfeOnsYAAAA with id 27562278
................................................................................
................................................................................
................................................................................
................................................................................
................................................................................
................................................................................
................................................................................
................................................................................
...............................................................
IE 11.0.0 (Windows 7.0.0) to satisfy assertion with an array satisfied against an array with async expect.it entries in the value should render unsatisfied entries FAILED
	Timeout of 2000ms exceeded. For async tests and hooks, ensure "done()" is called; if returning a Promise, ensure it resolves.
................................................................................
................................................................................
................................................................................
................................................................................
................
IE 11.0.0 (Windows 7.0.0): Executed 1040 of 1041 (1 FAILED) (skipped 1) (27.923 secs / 26.315 secs)
make: *** [test-browserstack-ie11] Error 1
The command "make $TARGET" exited with 2.

It succeeded when I retried it. Maybe 2 seconds is a bit too tight for these? @sunesimonsen

@papandreou
Copy link
Member

Landed manually on v11.

@papandreou papandreou closed this Dec 31, 2018
@depfu depfu bot deleted the depfu/update/npm/rollup-1.0.0 branch December 31, 2018 14:08
@papandreou
Copy link
Member

The timeout happened again on master just now. I increased the timeout for the browser tests to 10 seconds now, let's see if that helps.

We're already specifying a timeout of 20 seconds in mocha.opts, mostly because the "external" tests can be slow.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant