-
Notifications
You must be signed in to change notification settings - Fork 114
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Unfiltered-scalatest fetches old version of scalatest to classpath and throws up exception when using with scala 2.9.x #92
Comments
You can always call intransitive() on the dependency specification for th same effect, however you are likely to run into further problems since it wasn't compiled against the correct version of scalatest. Scalatest is not cross-published across major versions of Scala so it is a high-maintenance dependency for us to support. Unless someone wants to take responsibility for this module I'll have to remove it. |
I'd hate to see this module removed, since I am actively using it for my projects. So, if no one else volunteers, I would take responsibility for this module and also take care of this issue. By the way, I do not have these binary compatibility problems when using the module with Scala 2.9.0-1 and ScalaTest 1.6.1 for 2.9.0, so I assume the problem turned up with Scala 2.9.1. |
There's a middle of the road option, which is what we're now doing for But it's a really compelling option for the kind of code that you want |
While I generally like the idea of external git dependencies, there is another downside to it: At least the sbt-idea plugin does not produce anything useful when an external git dependency is involved in the SBT build definition, i.e. the git dependency does not exist in the IDE. I don't know if support for these external dependencies is better in other IDEs, but personally I currently end up deploying such modules to a private Maven repository to work around this, which is pretty annoying. I don't know if anyone else thinks this is a problem, but I thought I'd at least mention it. |
Funny I just heard the same thing from the Dispatch list. I hope they If you want to fix the build for the traditional maven-style artifact, |
I totally agree with you. I am going to submit an issue to the sbt-idea project. Hopefully, we'll soon see better support for external dependencies in IntelliJ. In the meantime, I am going to take responsibility for this module and fix the build for the traditional maven-style artifact. Thanks for the hint. I guess the most time-consuming part of this is to find the appropriate versions for each Scala version. |
Thanks Daniel! |
Here's an example project on how to reproduce the binary compatibility problem. Dependency should be declared as provided or something so it doesn't end up for the user of the library..
https://github.com/vvilhonen/binarybackward
The text was updated successfully, but these errors were encountered: