Deprecate QParams validation so that we can later remove it.
#274
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
October 19, 2014 14:48
This is used in the oauth and mac modules. It might be better to port those over to Directives in the same PR, as they generate a lot of deprecation warnings. Let's discuss before merging.
Since the error messages generated were just being thrown away, we can instead just `flatMap` through options.
|
The important part is that the conversion happens before this is released, and while I like the discreteness of this pull vs another to upgrade those modules (as one does not immediately necessitate the other), if you're feeling inspired ... |
|
Yeah, I'm concerned about not getting it done otherwise. I did the easy one, I'll take a crack at the harder one. |
added 5 commits
October 19, 2014 23:54
…te_qparams Conflicts: project/build.scala
…nces. Later we'll remove the references and leave the few plain Params tests that it has.
|
Finished with unfiltered-oauth, all that's left is unfiltered-oauth2. 😴 |
added 4 commits
October 20, 2014 22:22
This is a blunt translation of QParams code to directives, it could probably benefit from a comprehensive rewrite at some point. My aim was to preserve the exiting behavior. The tests pass.
|
OK, I've replaced the use of |
n8han
pushed a commit
that referenced
this pull request
Nov 12, 2014
Deprecate `QParams` validation so that we can later remove it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is used in the oauth and mac modules. It might be better to port
those over to Directives in the same PR, as they generate a lot of
deprecation warnings. Let's discuss before merging.