-
Notifications
You must be signed in to change notification settings - Fork 114
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Deprecate QParams
validation so that we can later remove it.
#274
Conversation
This is used in the oauth and mac modules. It might be better to port those over to Directives in the same PR, as they generate a lot of deprecation warnings. Let's discuss before merging.
Since the error messages generated were just being thrown away, we can instead just `flatMap` through options.
The important part is that the conversion happens before this is released, and while I like the discreteness of this pull vs another to upgrade those modules (as one does not immediately necessitate the other), if you're feeling inspired ... |
Yeah, I'm concerned about not getting it done otherwise. I did the easy one, I'll take a crack at the harder one. |
…te_qparams Conflicts: project/build.scala
…nces. Later we'll remove the references and leave the few plain Params tests that it has.
Finished with unfiltered-oauth, all that's left is unfiltered-oauth2. 😴 |
This is a blunt translation of QParams code to directives, it could probably benefit from a comprehensive rewrite at some point. My aim was to preserve the exiting behavior. The tests pass.
OK, I've replaced the use of |
Deprecate `QParams` validation so that we can later remove it.
This is used in the oauth and mac modules. It might be better to port
those over to Directives in the same PR, as they generate a lot of
deprecation warnings. Let's discuss before merging.