Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add site_favicon.html helper to skeleton.html #498

Closed
wants to merge 1 commit into from

Conversation

furkankurt
Copy link

Django Unfold doesn't have a favicon feature.
We had to override the whole skeleton.html template to add a favicon. Fixes #415

I have added a site_favicon.html file to the unfold/helpers directory, we can add all favicon types to the website.
Instead of overriding the skeleton.html, we will override just the site_favicon.html.

PS: I added example favicon links as template comments.

@furkankurt
Copy link
Author

Thank you so much for closing my pull request without saying anything.
Very clever and good work @lukasvinclav 👏🏻

@lukasvinclav
Copy link
Contributor

Ticket is still in backlog and it is pointing at this PR. Today I marked your ticket with a label "enhancement" and I was planning to start working on it very soon. Implementing favicon support is more complex than overriding simple template. It must have its own configuration in settings.py, docs, tests and support for various sizes so there is a lot of things to integrate.

I don't think there is place for such a reaction in open-source Django community which was always awesome. I'm just trying to ship new features and fixes as much as possible so there is no time to provide full fledged answers to everything in the repository. Thanks for understanding.

@furkankurt
Copy link
Author

Ticket is still in backlog and it is pointing at this PR. Today I marked your ticket with a label "enhancement" and I was planning to start working on it very soon. Implementing favicon support is more complex than overriding simple template. It must have its own configuration in settings.py, docs, tests and support for various sizes so there is a lot of things to integrate.

I don't think there is place for such a reaction in open-source Django community which was always awesome. I'm just trying to ship new features and fixes as much as possible so there is no time to provide full fledged answers to everything in the repository. Thanks for understanding.

Thank you for your explanation :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feat] Add Favicon feature
2 participants