Skip to content
This repository has been archived by the owner on Dec 7, 2023. It is now read-only.

Remove HTML font codes #243

Closed
jag3773 opened this issue Sep 17, 2015 · 7 comments
Closed

Remove HTML font codes #243

jag3773 opened this issue Sep 17, 2015 · 7 comments
Assignees
Labels

Comments

@jag3773
Copy link
Contributor

jag3773 commented Sep 17, 2015

From @jag3773 on July 23, 2015 20:40

The tN writers are all using the WYSIWYG editor and pasting in a large amount of HTML font code. Please create a script to automatically find and delete this code at least once per day.

This script should only check the en:bible:notes and en:obe namespaces. Some pages, such as https://door43.org/en/bible/home contain legitimate code. It is possible we may want to add other namespaces at a later date.

These pages show the current list of pages: https://door43.org/en/bible/resources/code/find-font-code-notes and https://door43.org/en/bible/resources/code/find-font-code-obe.

Copied from original issue: unfoldingWord-dev/tools#109

@jag3773
Copy link
Contributor Author

jag3773 commented Sep 17, 2015

From @lrsallee on July 23, 2015 21:0

Seems straight-forward, but let me know if you have any questions. larry_sallee@wycliffeassociates.org

@jag3773
Copy link
Contributor Author

jag3773 commented Sep 17, 2015

From @superdav42 on July 23, 2015 23:38

@jag3773 @lrsallee I think it would make a lot more sense to fix update the editor to strip out the font codes or update docuwiki to strip them out on save. Automatically running a global search and replace seems like a bad idea.

@jag3773
Copy link
Contributor Author

jag3773 commented Sep 17, 2015

From @lrsallee on July 24, 2015 1:37

David,

However you solve the problem is fine with us. We only care about the end result—not code throughout the text.

Larry

From: superdav42
Reply-To: unfoldingWord-dev/tools
Date: Thursday, July 23, 2015 at 7:38 PM
To: unfoldingWord-dev/tools
Cc: Larry Sallee
Subject: Re: [tools] Remove HTML font codes (#109)

@jag3773https://github.com/jag3773 @lrsalleehttps://github.com/lrsallee I think it would make a lot more sense to fix update the editor to strip out the font codes or update docuwiki to strip them out on save. Automatically running a global search and replace seems like a bad idea.


Reply to this email directly or view it on GitHubhttps://github.com/unfoldingWord-dev/tools/issues/109#issuecomment-124269634.

@jag3773
Copy link
Contributor Author

jag3773 commented Sep 17, 2015

From @alerque on July 30, 2015 5:35

I would concur with what @superdav42 said here. One additional benefit to doing this at the editor level (as a save hook or filter of some sort) has the major advantage of catching problems as they happen rather than later. If you do this later you might mess something up that the author saved and checked and thought was done and they moved on. Who knows when you would even catch that something unexpected happened. But if you do it as part of the save process, the editor that entered content in the first place will be checking the actual final result of their work and immediately be aware if there is a problem.

@lrsallee
Copy link

So, what does that mean for us. Is someone going to work on that editor level fix?

From: Jesse Griffin
Reply-To: unfoldingWord-dev/Door43
Date: Thursday, September 17, 2015 at 2:51 PM
To: unfoldingWord-dev/Door43
Cc: Larry Sallee
Subject: Re: [Door43] Remove HTML font codes (#243)

From @alerquehttps://github.com/alerque on July 30, 2015 5:35

I would concur with what @superdav42https://github.com/superdav42 said here. One additional benefit to doing this at the editor level (as a save hook or filter of some sort) has the major advantage of catching problems as they happen rather than later. If you do this later you might mess something up that the author saved and checked and thought was done and they moved on. Who knows when you would even catch that something unexpected happened. But if you do it as part of the save process, the editor that entered content in the first place will be checking the actual final result of their work and immediately be aware if there is a problem.


Reply to this email directly or view it on GitHubhttps://github.com//issues/243#issuecomment-141185858.

@jag3773
Copy link
Contributor Author

jag3773 commented Sep 17, 2015

Yes, it is on the roadmap.

@superdav42
Copy link
Contributor

@jag3773 PR #255

@jag3773 jag3773 closed this as completed Sep 29, 2015
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

No branches or pull requests

4 participants