Skip to content
This repository has been archived by the owner on Dec 7, 2023. It is now read-only.

Remove font tags from some namespaces on save #255

Merged
merged 4 commits into from
Sep 24, 2015

Conversation

superdav42
Copy link
Contributor

@jag3773
Copy link
Contributor

jag3773 commented Sep 22, 2015

@superdav42 can we modify this to remove the font tags from everything? We don't want them anywhere.

@superdav42
Copy link
Contributor Author

@jag3773 We can, but #243 said only do it on these namespaces. <font> tags are used by the ckgedit plugin under normal circumstances so if we always remove them certain features won't work, like all the font styling features.
see https://www.dokuwiki.org/plugin:ckgedit:font_styling

@jag3773
Copy link
Contributor

jag3773 commented Sep 22, 2015

Understood, we don't want the junk anywhere.

@superdav42
Copy link
Contributor Author

@jag3773 Alright, Updated to remove font tags everywhere.

@superdav42
Copy link
Contributor Author

Also included is update to tag plugin which searches multiple namespaces or excludes namespaces.
The tag plugin is a fork in my repo.

@richmahn
Copy link
Member

@jag3773 Is this good to go?

@richmahn
Copy link
Member

@superdav42 I see you changed the URI for this repo in the .gitmodules file. Will this have no problem in updating a running copy that has the dokufreak/tag repo to your repo? This needs to be tested.

@superdav42
Copy link
Contributor Author

@richmahn I'm not sure I haven't worked with submodules enough.
I could make this PR to a different branch if you want to test it. Someone else will have to create the branch on unfoldingWord-dev/Door43 since i don't have write access. That'd be the easiest way to test it I think.

@jag3773
Copy link
Contributor

jag3773 commented Sep 24, 2015

Yes regarding the font tag issue.
On Sep 23, 2015 11:59 AM, "Richard Mahn" notifications@github.com wrote:

@jag3773 https://github.com/jag3773 Is this good to go?


Reply to this email directly or view it on GitHub
#255 (comment)
.

@richmahn
Copy link
Member

going to merge this. I will work on the change of URI for the submodule to make sure it switches over easily.

richmahn added a commit that referenced this pull request Sep 24, 2015
Remove font tags from some namespaces on save
@richmahn richmahn merged commit 5c76dac into unfoldingWord-dev:development Sep 24, 2015
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants