Skip to content
This repository has been archived by the owner on Dec 5, 2023. It is now read-only.

Features/#289 add json metadata #302

Merged
merged 6 commits into from
Nov 16, 2015
Merged

Conversation

cdaield
Copy link
Contributor

@cdaield cdaield commented Nov 16, 2015

#289 and #295

Review on Reviewable

@jag3773
Copy link
Contributor

jag3773 commented Nov 16, 2015

:shipit:

language = models.ForeignKey(Language)
number = models.IntegerField()
ref = models.TextField()
ref = models.TextField(default=None, null=True)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For TextField and CharField setting to just blank=True is preferred, so as not not mix empty string and null as having two *falesyvalues to contend with.blank=True` will use an empty string by default on these fields.

@vleong2332
Copy link
Contributor

🚢

cdaield added a commit that referenced this pull request Nov 16, 2015
@cdaield cdaield merged commit e37e040 into develop Nov 16, 2015
@cdaield cdaield deleted the features/#289_add_json_metadata branch November 16, 2015 17:04
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants