This repository has been archived by the owner on Dec 5, 2023. It is now read-only.
Updates to Questionnaire API endpoint (#607) #621
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Update the response for /api/questionnaire Language direction is now indicated with "ltr" or "rtl" as opposed to "l" or "r". This follows the pattern in langnames.json. Give additional field of "language_data", which tells which question maps to which property on a language. * Fix flake8 error(s) * Change questionnaire API view to class-based; Write unit-tests The receiving endpoint now supports raw JSON data, instead of just POST form-data. Resolves #603
* Initial integration of django_comments and django-taggit * Customize Tag from django-taggit We need a Tag model/table to be some sort of "tag register" that lists models (WARegion, Country, Language, Charter, Event are intendended) alongside their tag slug. In other words, it need to keys to one of the models in addition to the comment. In admin, we'll use this custom tag (CommentTag) instead of django-taggit's Tag. * Add tag_slug property to WARegion, Country, Language, Charter, and Event * Create management command to update CommentTag * Add receivers and handler function to update comment tag * Add hashtag info to WARegion, Country, Language, Charter, and Event detail page * Parse hashtags in comments * Add comment sections to Country, Language, and Event * Add commenting to charter tab under language * Add filter for all, originals, and mentions * Add commenting management commands * Display object name instead of the tag slug * Prep work for review Adjust tag slugging rule to use language's ISO-639-3 instead of its code (IETF) if the code has less than 3 letters. Fix duplicate comments and comment counts when writing a comment that mentions itself. Add missing "mentions" property to Charter and Event. * Let comments and mentions be called as an object property. Abstract out tags and comments properties in CommentableModel. * Put events' comments under Translation Work tab in Language detail * Make post_comment a class-based view * Fix broken unit-tests IntegrityError in create_comment_tag() causes database to close connection early. Hence breaking the rest of the unit-tests. * Add ability to delete one's own comment * Write unit-tests
The denominator doesn't take into account which phase are we looking at. As a result phase 1 completion percentage is divided against phase 1 and phase 2 word count, which results in a much lower number.
…abaseWeb into develop
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Language direction is now indicated with "ltr" or "rtl" as opposed to
"l" or "r". This follows the pattern in langnames.json.
Give additional field of "language_data", which tells which question
maps to which property on a language.
The receiving endpoint now supports raw JSON data, instead of just POST form-data.
Resolves #603
This change is