Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug fixes #1282

Merged
merged 13 commits into from
Nov 11, 2019
Merged

Bug fixes #1282

merged 13 commits into from
Nov 11, 2019

Conversation

da1nerd
Copy link
Contributor

@da1nerd da1nerd commented Nov 1, 2019

@da1nerd da1nerd self-assigned this Nov 1, 2019
@da1nerd
Copy link
Contributor Author

da1nerd commented Nov 1, 2019

There are some builds that can be tested at https://github.com/unfoldingWord-dev/ts-desktop/releases/tag/untagged-10c13b04372bb62773d2

@elsylambert
Copy link

elsylambert commented Nov 1, 2019

@neutrinog Tried to upgrade from 11.1 to 12.1.1((Hotfix) build), system is hung after I clicked on the .exe file.
image

@da1nerd
Copy link
Contributor Author

da1nerd commented Nov 4, 2019

@elsylambert I'm not able to reproduce that. Is it consistently freezing every time?

@elsylambert
Copy link

@neutrinog Yes, consistently every time.
These are the steps I followed:

  1. Did a clean install of 11.1.
  2. Imported a project and made edits.
  3. Downloaded 12,1,1 hotfix build.
  4. Clicked on the .exe file to install.
    My cursor kept spinning forever till I ended the Task, I ended up rebooting my computer.
    I tried this three times.

@elsylambert
Copy link

I tried once again this morning and v12.1.1 build 146 got installed successfully. Upgraded from v 11.1 to v 12.1.1.

@elsylambert
Copy link

@neutrinog - Upgrade from 11.1 to 12.1.1 is working fine in windows 64-bit machine.

  • Clean Install of 12.1.1 is working fine.

@da1nerd da1nerd changed the title fixed closing bug on mac and install bug on windows Bug fixes Nov 6, 2019
@da1nerd
Copy link
Contributor Author

da1nerd commented Nov 6, 2019

@elsylambert I have some new builds for you to try out https://github.com/unfoldingWord-dev/ts-desktop/releases/tag/untagged-d99fe0490159afc118fb

These should fixes all the outstanding bugs. However, please note that downloading kn will continue to fail until the content has been fixed and published.

@elsylambert
Copy link

Verified in v12.1.1 build 147.

  • Clean Installtion and upgrade from 11.1 works fine.
  • kn tA download works fine.
  • kn tA article jumps to the selected Article.

@da1nerd
Copy link
Contributor Author

da1nerd commented Nov 7, 2019

@elsylambert
Copy link

Verified in v12.1.1 build 148.
All the mentioned issues are fixed.

@jag3773 jag3773 merged commit 83ee25a into master Nov 11, 2019
@da1nerd da1nerd deleted the hotfix-12.1.1 branch November 14, 2019 16:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants