setting dstuser file ownership in __ssh_authorized_key #52
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| # that user's ownership credentials | ||
| if [ "$dstuser" ]; then | ||
| __directory $sshpath --owner $dstuser --group $dstuser --mode 700 | ||
| # if no destination user is defined, create the .ssh directory as root |
There was a problem hiding this comment.
What about a group being different named then the user?
There was a problem hiding this comment.
I believe that using --owner could always be done (root or $dstuser)
I think we can even setup dstuser=root, if dstuser is not given
There was a problem hiding this comment.
Maybe add a --ssh-directory-group parameter?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was having trouble logging in as a __ssh_authorized_key provisioned user after the /home/$dstuser/.ssh/authorized_key file was created, which I believe was due to permissions not being properly set on the $dstuser's files. This commit gives $dstuser (if defined) ownership of the .ssh directory and authorized_keys file, allowing them to log in.