Update to 71.0.3578.80 #618

xsmile · 2018-12-07T14:58:46Z

removed gn-bootstrap-remove-gn-gen.patch, --skip_generate_buildfiles can now be used to skip this step
~~removed add-flag-to-show-avatar-button.patch, the new UI places the avatar button in line with the settings button instead of the title bar and switching to the old UI is not possible anymore~~

- gn-bootstrap-remove-gn-gen.patch: Removed, `--skip_generate_buildfiles` can now be used to skip this step - add-flag-to-show-avatar-button.patch: Removed, the avatar button does not occupy the title bar anymore

ghost · 2018-12-07T17:39:20Z

Thank you. It builds fine for me.

qvint · 2018-12-08T06:12:46Z

removed add-flag-to-show-avatar-button.patch, the new UI places the avatar button in line with the settings button instead of the title bar and switching to the old UI is not possible anymore

Does the patch stop working in version 71? Did you check that? It works for both UIs in version 70.

perfect7gentleman · 2018-12-08T11:09:52Z

 ~ $ chromium

(chromium-browser:17169): Gtk-WARNING **: 18:08:42.659: Theme parsing error: gtk.css:68:35: The style property GtkButton:child-displacement-x is deprecated and shouldn't be used anymore. It will be removed in a future version

(chromium-browser:17169): Gtk-WARNING **: 18:08:42.659: Theme parsing error: gtk.css:69:35: The style property GtkButton:child-displacement-y is deprecated and shouldn't be used anymore. It will be removed in a future version

(chromium-browser:17169): Gtk-WARNING **: 18:08:42.659: Theme parsing error: gtk.css:73:46: The style property GtkScrolledWindow:scrollbars-within-bevel is deprecated and shouldn't be used anymore. It will be removed in a future version
Aborted

ghost · 2018-12-08T11:41:48Z

@perfect7gentleman Those warnings comes from the theme engine, I think, and shouldn't cause an abort. On another issue tracker, I saw that you are using Clang as the default toolchain, yes? If so, you should double-check if you properly built chromium's dependencies, specially C++ ones.

I had similar issue when tried to build against libcxx/libcxxabi.

perfect7gentleman · 2018-12-08T11:57:58Z

@ian-moone , Clang is default for chromium deps such as nodejs and others. New dep introduced in 71, jsoncpp, is also built with Clang.

 ~ $ cat /etc/portage/env/O3_clang 
CC="clang"
CXX="clang++"
CFLAGS="-march=native -mtune=native -O3 -pipe -fomit-frame-pointer -fno-stack-protector -flto=thin -flto-jobs=9 -fuse-ld=lld"
CXXFLAGS="${CFLAGS} -stdlib=libc++"
LDFLAGS="-Wl,-O2 -Wl,--as-needed -Wl,--strip-debug -Wl,--thinlto-jobs=9 -flto=thin -fuse-ld=lld"
AR="llvm-ar"
NM="llvm-nm"
RANLIB="llvm-ranlib"

 ~ $ emerge -avtp clang llvm libcxx libcxxabi

[ebuild   R   #] sys-devel/clang-7.0.1_rc2:7::gentoo  USE="default-compiler-rt default-libcxx -debug -doc -static-analyzer -test -xml (-z3)" LLVM_TARGETS="(X86) -AArch64 -AMDGPU -ARM -BPF -Hexagon -Lanai -MSP430 -Mips -NVPTX -PowerPC -Sparc -SystemZ -XCore" PYTHON_TARGETS="python2_7" 13,076 KiB
[ebuild   R   #]  sys-libs/libcxx-7.0.1_rc2::gentoo  USE="libcxxabi libunwind -libcxxrt -static-libs -test" 1,603 KiB
[ebuild   R   #]   sys-libs/libcxxabi-7.0.1_rc2::gentoo  USE="libunwind -static-libs -test" 523 KiB
[ebuild   R   #]    sys-devel/llvm-7.0.1_rc2:7::gentoo  USE="gold libffi ncurses -debug -doc -exegesis -libedit -test -xar -xml" LLVM_TARGETS="(X86) -AArch64 -AMDGPU -ARM -BPF -Hexagon -Lanai -MSP430 -Mips -NVPTX -PowerPC -Sparc -SystemZ -XCore" 27,642 KiB

xsmile · 2018-12-08T12:11:16Z

Does the patch stop working in version 71? Did you check that? It works for both UIs in version 70.

I checked it briefly and it requires updating as code referencing the old UI was removed. If needed, I can update and include it again.

ghost · 2018-12-08T12:16:32Z

Have you successfully built chromium against libcxx/libxxabi in the past? Because I don't. I had to build dev-libs/re2, dev-libs/jsoncpp and of course, chromium itself with:

CXXFLAGS="${CFLAGS} -stdlib=libstdc++"
LDFLAGS="-Wl,-O2 -Wl,--as-needed -fuse-ld=lld -Wl,-lgcc_s"

perfect7gentleman · 2018-12-08T12:20:22Z

ave you successfully built chromium against libcxx/libxxabi in the past?

yes, and lastest ungoogled-chromium-70 too.

I had to build dev-libs/re2, dev-libs/jsoncpp

they are built with Clang

ghost · 2018-12-08T12:40:04Z

I'm not sure if chromium truly supports system libcxx on linux yet. At least looking at the build/config/compiler/BUILD.gn, libc++ are only related to Mac, like this one:

  if (is_mac) {
    # The system libc++ on Mac doesn't have aligned allocation in C++17.
    defines += [ "_LIBCPP_HAS_NO_ALIGNED_ALLOCATION" ]
    cflags_cc += [ "-stdlib=libc++" ]
    ldflags += [ "-stdlib=libc++" ]
  }

The other references are when use_custom_libcxx == true, which uses the bundled toolchain. So I suggest that you should stick to libstdc++ for now. Or at least try it, and see if that works for you.

perfect7gentleman · 2018-12-08T12:53:29Z

I don't see any big differences between ebuilds for 70 and 71. Only jsonccp as new dep.

ghost · 2018-12-08T12:56:13Z

Yeah, but chromium's internals could've changed a lot between them.

qvint · 2018-12-08T19:02:46Z

@xsmile Please update the patch, it is fixed now.

xsmile · 2018-12-08T22:56:12Z

@xsmile Please update the patch, it is fixed now.

Thank you, I included it again.

Eloston · 2018-12-08T20:32:26Z

patches/debian_buster/fixes/ambiguous-overloads.patch

@@ -0,0 +1,23 @@
+description: gcc6 cannot automatically resolve these overloads, tell it what to do


I don't think it is necessary to have this patch considering that all of this code will be removed in disable-google-host-detection.patch

Eloston · 2018-12-08T20:50:36Z

patches/debian_buster/system/fontconfig.patch

-# was reverted since it
-# - breaks linux_portable.
-# - has no clear side-effects (the include only defines constants).
-# - has nothing to do with fontconfig.


Please don't revert this.

FYI, I've been trying to develop a new workflow for updating Debian-related patches and packaging files. It should be able to catch cases like this. The instructions for this workflow are here: https://github.com/ungoogled-software/ungoogled-chromium-debian. That being said, I don't think it is necessary to re-work this PR using that workflow. If you decide to try it out for the next release, let me know how it goes.

Right, fixed.
Thanks for the instructions, I'll take a look next time.

Eloston · 2018-12-08T20:54:22Z

patches/debian_buster/system/gtk2.patch

@@ -0,0 +1,1655 @@
+description: restore support for building against gtk2


I don't have any configurations that use the GTK2 UI. I'm guessing it is not necessary to include this?

This is optional, I removed the patch.

Eloston · 2018-12-08T23:18:42Z

patches/debian_buster/warnings/explicit-constructor.patch

     return;

   // Delete any remaining pending requests on this Channel ID.
 -  pending_transactions_ = {};
-+  pending_transactions_ = base::queue<std::pair<std::vector<uint8_t>, DeviceCallback>>();


I manually added this line back in because I wasn't sure if removing this line would cause any issues or not.

Eloston · 2018-12-08T23:33:41Z

Whoops, I only wanted 8c49d06 to be approved again, not the entire PR...

Eloston

Looks good now. Thanks.

xsmile added 9 commits December 7, 2018 15:39

patches/bromite: Update to 71.0.3578.80

2173f64

patches/debian_buster: Update to 71.0.3578.80

8282cc2

patches/inox: Update to 71.0.3578.80

3462471

patches/iridium: Update to 71.0.3578.80

e0e1587

patches/ungoogled: Update to 71.0.3578.80

88c2c14

- gn-bootstrap-remove-gn-gen.patch: Removed, `--skip_generate_buildfiles` can now be used to skip this step - add-flag-to-show-avatar-button.patch: Removed, the avatar button does not occupy the title bar anymore

bundles/common: Update to 71.0.3578.80

09412b7

bundles/linux_rooted: Update to 71.0.3578.80

5115f81

Update lists to 71.0.3578.80

123410a

Update version to 71.0.3578.80

797be6e

xsmile force-pushed the 71 branch from ac6ac74 to 797be6e Compare December 7, 2018 15:16

Restore add-flag-to-show-avatar-button.patch

8c49d06

Eloston requested changes Dec 8, 2018

View reviewed changes

Eloston approved these changes Dec 8, 2018

View reviewed changes

Eloston added this to the 71.x.x.x milestone Dec 9, 2018

Eloston added the enhancement label Dec 9, 2018

Remove ambiguous-overloads.patch

1d83c28

xsmile added 4 commits December 9, 2018 01:58

Restore changes in fontconfig.patch

4b28bf2

Remove gtk2.patch

54fa65c

Restore changes in explicit-constructor.patch

791c3cb

Update bundles and refresh patches

907d2a3

bendlas mentioned this pull request Dec 9, 2018

chromium: Add ungoogled flag to enable ungoogled-chromium patches NixOS/nixpkgs#51195

Closed

10 tasks

Eloston approved these changes Dec 9, 2018

View reviewed changes

Eloston merged commit 907d2a3 into ungoogled-software:master Dec 9, 2018

xsmile deleted the 71 branch January 31, 2019 14:34

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Update to 71.0.3578.80 #618

Update to 71.0.3578.80 #618

xsmile commented Dec 7, 2018 •

edited

ghost commented Dec 7, 2018

qvint commented Dec 8, 2018

perfect7gentleman commented Dec 8, 2018

ghost commented Dec 8, 2018 •

edited by ghost

perfect7gentleman commented Dec 8, 2018 •

edited

xsmile commented Dec 8, 2018

ghost commented Dec 8, 2018

perfect7gentleman commented Dec 8, 2018 •

edited

ghost commented Dec 8, 2018 •

edited by ghost

perfect7gentleman commented Dec 8, 2018

ghost commented Dec 8, 2018 •

edited by ghost

qvint commented Dec 8, 2018 •

edited

xsmile commented Dec 8, 2018

Eloston Dec 8, 2018

xsmile Dec 9, 2018

Eloston Dec 8, 2018

xsmile Dec 9, 2018

Eloston Dec 8, 2018

xsmile Dec 9, 2018

Eloston Dec 8, 2018

xsmile Dec 9, 2018

Eloston commented Dec 8, 2018

Eloston left a comment

		@@ -0,0 +1,23 @@
		description: gcc6 cannot automatically resolve these overloads, tell it what to do

		@@ -0,0 +1,1655 @@
		description: restore support for building against gtk2

Update to 71.0.3578.80 #618

Update to 71.0.3578.80 #618

Conversation

xsmile commented Dec 7, 2018 • edited

ghost commented Dec 7, 2018

qvint commented Dec 8, 2018

perfect7gentleman commented Dec 8, 2018

ghost commented Dec 8, 2018 • edited by ghost

perfect7gentleman commented Dec 8, 2018 • edited

xsmile commented Dec 8, 2018

ghost commented Dec 8, 2018

perfect7gentleman commented Dec 8, 2018 • edited

ghost commented Dec 8, 2018 • edited by ghost

perfect7gentleman commented Dec 8, 2018

ghost commented Dec 8, 2018 • edited by ghost

qvint commented Dec 8, 2018 • edited

xsmile commented Dec 8, 2018

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Eloston commented Dec 8, 2018

Eloston left a comment

Choose a reason for hiding this comment

xsmile commented Dec 7, 2018 •

edited

ghost commented Dec 8, 2018 •

edited by ghost

perfect7gentleman commented Dec 8, 2018 •

edited

perfect7gentleman commented Dec 8, 2018 •

edited

ghost commented Dec 8, 2018 •

edited by ghost

ghost commented Dec 8, 2018 •

edited by ghost

qvint commented Dec 8, 2018 •

edited