Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Onboarding docs with contribution guidelines #115

Draft
wants to merge 11 commits into
base: main
Choose a base branch
from

Conversation

sabinevidal
Copy link
Collaborator

@sabinevidal sabinevidal commented Jan 7, 2022

Adding a contributions section to the docs website to outline how and where people can contribute.

Still to do:

  • copy for the sections
  • Onboarding workflow with Swagger?
  • Guidelines for API integration
  • Links to issue template and contribution guidelines/policy
  • Link to docs on kindly-website

@sabinevidal sabinevidal linked an issue Jan 7, 2022 that may be closed by this pull request
@sabinevidal sabinevidal self-assigned this Jan 24, 2022
@sabinevidal sabinevidal added the documentation Improvements or additions to documentation label Jan 24, 2022
@sabinevidal
Copy link
Collaborator Author

@nathanfletcher @jwflory: I have added more info into the overview.
I want to flesh out the docs overview a little bit more as this would likely be a first stopping point for new contributors.
I thought we could include the contribution guidelines (mentioned in #125) on the api maintenance page.
Would appreciate your thoughts when you have a chance, on where I can add more or less detail. Thanks!

@nathanfletcher
Copy link
Contributor

@sabinevidal it seems the docs check failed because of a url https://github.com/unicef/kindly/runs/5067906279?check_suite_focus=true#step:4:36

I think it looks okay but I'd like to hear what Justin also thinks of the changes

Copy link
Member

@jwflory jwflory left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shared some quick thoughts on the contributing guidelines. Let me know what you think or if my comments make sense.

docs-website/docs/contributing/overview.md Outdated Show resolved Hide resolved
We are collecting training data from children on the [Kindly website](https://kindly.unicef.io/contribute). These contributions will be added to the [training dataset](ml-model/training-data) which are classified as either `offensive` or `non-offensive` to improve the model's accuracy. See the [training data docs](../ml-model/training-data) for a more technical overview.

## [API Maintenance](api-maintenance)
Kindly is built as an open-source solution, and is a certified [DPG](https://digitalpublicgoods.net/registry/kindly.html). We are on [GitHub](https://github.com/unicef/kindly) and will welcome your help whatever your skills.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What do you think about creating a new label for API-related issues, e.g. type: API or something similar? This way, it will be easier to discover API-related tasks that someone could work on.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like this idea!
I think I might also rename the 'API maintenance' section to something more like 'project maintenance', as it'll not just be for the API, and there are other aspects where people cam contribute (including the current front-facing website)

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree, it opens up more room for participation. 👍🏻

Kindly is built as an open-source solution, and is a certified [DPG](https://digitalpublicgoods.net/registry/kindly.html). We are on [GitHub](https://github.com/unicef/kindly) and will welcome your help whatever your skills.

## [API Integration](api-integration)
Integrate the Kindly API with your own program.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does the API have any documentation already? If so, could we link to it from here?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's a page in the docs for the API, it includes the endpoints https://unicef.github.io/kindly/api. But might be worth elaborating a little bit more for those who are new to APIs ie, that they'd have to integrate it into an existing text input.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@sabinevidal It is a nice idea but could also be a long-term goal of providing more examples or guidance of integrating Kindly into an existing app. I think cross-linking to the existing API documentation will be enough for any developer who is taking a peek at Kindly and looking to understand what they can do with it.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jwflory: @nathanfletcher is building out a better API overview with SwaggerAPI, so will cross-link that here once it's complete.
Will note the API crash-course idea for a future goal - I know @amreenp7 was in the process of talking to people about creating course material for children incorporating Kindly - so could be included in that discussion.

Check out the [development docs](../technical/development) to see how to set up a development environment so you can work on the Kindly repo.
Our backend is set up as an API, so you can also make calls to this on Postman or with `curl`. We also have a [website](https://kindly.unicef.io) where you can check phrases with Kindly, alternatively once you've set up the development environment you can use the [web client](../overview#web-client) to test phrases.

## Contribution Guidelines
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@nathanfletcher We can maybe add the guidelines at this point? Or even a link if we're doing them somewhere else.

@sabinevidal
Copy link
Collaborator Author

@nathanfletcher:
Here's the PR for the contribution docs updates!

@sabinevidal
Copy link
Collaborator Author

@nathanfletcher @jwflory
Is there anything else I need to add to the docs from updates the last month?
Also need to add the link + info for the SwaggerAPI as well as the guidelines/code of conduct for contributions too.

@jwflory
Copy link
Member

jwflory commented May 7, 2022

@nathanfletcher Is this PR ready for final review?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Onboarding Workflow
3 participants