Skip to content
This repository has been archived by the owner on Oct 7, 2022. It is now read-only.

Write about CI & Code health checks in the Docs #39

Merged
merged 11 commits into from
Aug 13, 2018
Merged

Conversation

thoat
Copy link
Contributor

@thoat thoat commented Jul 11, 2018

As suggested by @jwflory here, I started a draft to fill in two sections in the GitHub Workflow article for our ReadTheDocs:

  • Set up continuous integration
  • Set up code health checks with CodeClimate

This is still a work in progress but @jwflory and everyone feels free to jump in if you find certain sentences too complicated to read or some procedures just plain wrong.

I hope to finish this either by the end of this week (Jul 9-13) or early next week (Jul 16-20).

@thoat thoat added the docs Adding or updating documentation label Jul 11, 2018
@jwflory
Copy link
Member

jwflory commented Jul 13, 2018

@thoat The content looks good to me – if you want me to review the final content, let me know and I'm happy to do so. 🙂

One note that I realized I forgot to put in the contributing guidelines: when writing sentences in the docs, it's convenient to write each sentence on a new line. This is awkward to write, but when it comes to reviewing changes to the docs, it makes reviewing the diff in a pull request really easy. I would recommend putting each sentence on a new line.

@thoat
Copy link
Contributor Author

thoat commented Jul 13, 2018

You're absolutely right re: the line-by-line writing, @jwflory. (y) I start getting dizzy looking at the clumps of text haha. Thanks so much for the heads-up.

@jwflory
Copy link
Member

jwflory commented Jul 14, 2018

@thoat Yup, no problem. To be fair, it's not a widely-practiced convention, but I think it's more practical – it makes reading diffs so much easier.

Also, this could be a good thing to make note of in the contributing guidelines for the docs. 🙂

@jwflory
Copy link
Member

jwflory commented Aug 3, 2018

Since #40 was merged, it introduces some merge conflicts with this PR. I recommend rebasing this branch against the current master branch of the repository. Rebasing is a convenient way of pulling in new changes to a project since you added work, apply them to the project, and then try to put your changes back on top of the git history.

I recommend reading this blog post or checking out the Open edX lesson on rebasing if you haven't done it before. These were both really helpful for me. 🙂

@thoat
Copy link
Contributor Author

thoat commented Aug 6, 2018

Thank you for the heads-up @jwflory ! And thank you for pointing out the direction and resources!

@thoat
Copy link
Contributor Author

thoat commented Aug 7, 2018

At this moment, I think there should be a new section on how to set up testing framework for a new repository. It involves more design/planning decision going into it, which is beyond the scope of this PR. Hence I have added a new sub-section to the docs via commit 3b9d69f, and thereby completing the sub-section on CodeClimate.

You can view my local run of the docs here.

@thoat thoat changed the title [WIP] Write about CI & Code health checks in the Docs Write about CI & Code health checks in the Docs Aug 7, 2018
@thoat thoat requested review from jwflory and vinitveersingh and removed request for vinitveersingh August 7, 2018 04:26
@mikefab mikefab merged commit 39e1af5 into unicef:master Aug 13, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
docs Adding or updating documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants