-
Notifications
You must be signed in to change notification settings - Fork 367
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CLDR-14493 Rework CLDR-2698/PR-964 changes to make nb a child of no, not an alias to it #1031
CLDR-14493 Rework CLDR-2698/PR-964 changes to make nb a child of no, not an alias to it #1031
Conversation
…nstead of an alias to it
@@ -59,7 +59,7 @@ | |||
<dayPeriodRule type="evening1" from="18:00" before="24:00"/> <!-- aften --> | |||
<dayPeriodRule type="night1" from="00:00" before="05:00"/> <!-- nat --> | |||
</dayPeriodRules> | |||
<dayPeriodRules locales="no"> | |||
<dayPeriodRules locales="nb no"> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Don't think this is necessary because plurals do inheritance, but doesn't hurt.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM…
Norwegian,nb, | ||
Norwegian Extended,nb,extended | ||
NorwegianSami-PC,nb,extended-var |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i don't know how the keyboard files are used, but seems plausible
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I was assuming that what was being referred to here was the locale ID used on the platform. But this actually goes back to the code that was used in CLDR 38, I had chnaged in my previous Norwegian PR since nb was no longer valid.
@@ -1669,7 +1669,7 @@ http://www.wikidata.org/entity/Q23014 pfl | |||
http://www.wikidata.org/entity/Q23526 sla | |||
http://www.wikidata.org/entity/Q23855 auq | |||
http://www.wikidata.org/entity/Q25164 nn | |||
http://www.wikidata.org/entity/Q25167 no | |||
http://www.wikidata.org/entity/Q25167 nb |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a generated file. Will have to watch it when its next generated.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a snapshot for review purposes (an output, not an input). The actual content is regenerated in the ST. So this may not work properly and may need some followon. Shouldn't hold this PR though. s
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I had looked up what that Wikidata entity referred to and it is in fact nb, not no. I had changed it before when we aliasing so no really meant nb.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@pedberg-icu right, but nothing reads entityToCode.tsv, it's output to give a historical record of the process.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you Peter! 👍
Checklist
The changes in CLDR-2698 / PR-964 swapped the role of nb and no, making nb a deprecated alias to no, and removing the xml files for nb, while also making no a parent locale with child nn. The first part of this would have caused serious compatibility problems for some CLDR and ICU clients, including Windows.
This PR reworks those changes to make no a parent of both nb and no; nb is not deprecated or aliased. All of the xml files that used to be present for nb and nn are restored in this PR, though in some cases their content has been moved elsewhere (as in the previous PR) so that the nb/nn xml files restored in this PR are all empty stubs. This includes having empty stubs in collation/ for nb and nn; however the "actual" collation content for these is in no.
Some constraints/considerations/changes in this PR: