CLDR-14954 Add Abkhazian locale to CLDR #1402

danielinux7 · 2021-08-09T11:48:32Z

CLDR-14954

This PR completes the ticket.
Updated PR title and link in previous line to include Issue number.

jira-pull-request-webhook · 2021-08-09T11:49:08Z

Hooray! The files in the branch are the same across the force-push. 😃

~ Your Friendly Jira-GitHub PR Checker Bot

srl295 · 2021-08-10T19:16:57Z

Followon from #1392

jira-pull-request-webhook · 2021-08-11T09:58:43Z

Hooray! The files in the branch are the same across the force-push. 😃

~ Your Friendly Jira-GitHub PR Checker Bot

danielinux7 · 2021-08-11T11:42:13Z

Error: (TestBasic.java:815) : likelyMax(locale=ab_JO) == likelyMax(defaultContent=ab): expected "ab_Cyrl_GE", got "ab_Cyrl_JO"

java.lang.InternalError: SupplementalData.defaultContentToChild(): defaultContent list in wrong order? Tried to map ab -> ab_JO, replacing ab_GE
Hello,
@srl295 would you have an idea how to fix these errors?

jira-pull-request-webhook · 2021-08-11T14:32:54Z

Hooray! The files in the branch are the same across the force-push. 😃

~ Your Friendly Jira-GitHub PR Checker Bot

srl295 · 2021-08-11T16:09:58Z

common/supplemental/attributeValueValidity.xml

@@ -10,7 +10,7 @@
 			<!-- This list contains ONLY those languages considered to be 'of interest' as part of CLDR, -->
 			<!-- and is maintained manually by the CLDR TC -->
 			<variable id='$language' type='choice'>
-				af agq ak am ar as asa ast az
+				ab af agq ak am ar as asa ast az


I'm not sure this is supposed to move here, this is not 'all locales'.

@macchiati might know. This is all probably too late for cldr v40

@danielinux7 why was ab moved here?

@srl295 I looked at what others did to add a new locale and I did the same.
This is one of the files they modified.
https://unicode-org.atlassian.net/browse/CLDR-13901

srl295 · 2021-08-11T16:10:23Z

common/supplemental/supplementalMetadata.xml

@@ -1652,7 +1652,7 @@ For terms of use, see http://www.unicode.org/copyright.html
            <zoneAlias type="Asia/Kashgar" replacement="Asia/Urumqi" reason="deprecated"/>
        </alias>
 		<defaultContent locales="
-			aa_ET af_ZA agq_CM ak_GH am_ET an_ES ar_001 arn_CL as_IN asa_TZ ast_ES
+			aa_ET ab_GE ab_JO ab_RU ab_SY ab_TR af_ZA agq_CM ak_GH am_ET an_ES ar_001 arn_CL as_IN asa_TZ ast_ES


need to choose just one. Maybe just ab_TR if most speakers are there?

jira-pull-request-webhook · 2021-08-11T17:57:21Z

Hooray! The files in the branch are the same across the force-push. 😃

~ Your Friendly Jira-GitHub PR Checker Bot

jira-pull-request-webhook · 2021-08-11T18:27:08Z

Hooray! The files in the branch are the same across the force-push. 😃

~ Your Friendly Jira-GitHub PR Checker Bot

srl295

looking better

srl295

needs to pass tests

danielinux7 · 2021-08-11T18:58:02Z

@srl295 I kept ab_TR but I am still getting these errors:
Error: (TestBasic.java:815) : likelyMax(locale=ab_TR) == likelyMax(defaultContent=ab): expected "ab_Cyrl_GE", got "ab_Cyrl_TR"

Error: (TestInheritance.java:604) likely subtag inconsistent with default contents: ab =>( dc) ab_TR ab => (ls) ab_Cyrl_GE

I think it has to do with this file:
cldr/common/supplemental/likelySubtags.xml

srl295 · 2021-08-11T19:53:37Z

@srl295 I kept ab_TR but I am still getting these errors:
Error: (TestBasic.java:815) : likelyMax(locale=ab_TR) == likelyMax(defaultContent=ab): expected "ab_Cyrl_GE", got "ab_Cyrl_TR"

Error: (TestInheritance.java:604) likely subtag inconsistent with default contents: ab =>( dc) ab_TR ab => (ls) ab_Cyrl_GE

I think it has to do with this file:
cldr/common/supplemental/likelySubtags.xml

Probably due to population (?) it may consider GE a more likely defaultContent. Is that possible? should ab_GE be the default content?

danielinux7 · 2021-08-11T20:53:44Z

Probably due to population (?) it may consider GE a more likely defaultContent. Is that possible? should ab_GE be the default content?

defaultContent should be ab_AB, Abkhazia which is partially a recognized territory, but not getting into this mess right now, I want to just add the language to v40.
Let defaultContent be just ab without territory.

srl295 · 2021-08-11T21:46:32Z

Probably due to population (?) it may consider GE a more likely defaultContent. Is that possible? should ab_GE be the default content?

defaultContent should be ab_AB, Abkhazia which is partially a recognized territory, but not getting into this mess right now, I want to just add the language to v40.
Let defaultContent be just ab without territory.

needs a territory. can you set ab_GE?

and as i said this might not make v40 but perhaps right after

jira-pull-request-webhook · 2021-08-11T21:51:07Z

Hooray! The files in the branch are the same across the force-push. 😃

~ Your Friendly Jira-GitHub PR Checker Bot

jira-pull-request-webhook · 2021-08-11T23:06:23Z

Hooray! The files in the branch are the same across the force-push. 😃

~ Your Friendly Jira-GitHub PR Checker Bot

danielinux7 · 2021-08-11T23:36:20Z

needs a territory. can you set ab_GE?

Done.

and as i said this might not make v40 but perhaps right after

Okay, I'll do what I can from my end to update the survey tool with the required data. It would be nice to have it in v40.

The test is passing.

jira-pull-request-webhook · 2021-08-13T16:22:18Z

Hooray! The files in the branch are the same across the force-push. 😃

~ Your Friendly Jira-GitHub PR Checker Bot

jira-pull-request-webhook · 2021-08-13T16:45:57Z

Hooray! The files in the branch are the same across the force-push. 😃

~ Your Friendly Jira-GitHub PR Checker Bot

danielinux7 · 2021-08-13T17:03:49Z

@srl295
Hello Steven,
I made the changes and the tests are passing.

srl295 · 2021-08-13T17:11:20Z

@danielinux7 I'm rerunning tests

common/supplemental/supplementalData.xml

See #1402

jira-pull-request-webhook · 2021-08-13T17:59:27Z

Hooray! The files in the branch are the same across the force-push. 😃

~ Your Friendly Jira-GitHub PR Checker Bot

danielinux7 · 2021-08-13T18:04:13Z

@srl295 @pedberg-icu
I removed ab_TR.
Is this looking good?

srl295 · 2021-08-13T18:43:04Z

tests are passing. I've asked the CLDR-TC about approving the ticket.

srl295 · 2021-08-13T19:49:12Z

@pedberg-icu look OK to you now?

pedberg-icu · 2021-09-28T08:40:50Z

Yes, looks good to me.

Add the Abkhazian language in the Georgia territory The ab_GE was just recently added to CLDR, it should be available in CLDR v41, unicode-org/cldr#1402 The Abkhazian language has been added to Gnome for localization The locale has been tested on Ubuntu 20.04, Mint 20.2 and Fedora 35 Beta Signed-off-by: Nart Tlisha <daniel.abzakh@gmail.com> Reviewed-by: Maxim Kuvyrkov <maxim.kuvyrkov@linaro.org>

srl295 reviewed Aug 11, 2021

View reviewed changes

srl295 requested a review from macchiati August 11, 2021 17:08

srl295 previously approved these changes Aug 11, 2021

View reviewed changes

srl295 reviewed Aug 11, 2021

View reviewed changes

srl295 self-requested a review August 11, 2021 18:51

danielinux7 dismissed srl295’s stale review via 81b0af1 August 11, 2021 20:30

danielinux7 marked this pull request as draft August 13, 2021 14:10

danielinux7 marked this pull request as ready for review August 13, 2021 17:01

pedberg-icu reviewed Aug 13, 2021

View reviewed changes

common/supplemental/supplementalData.xml Outdated Show resolved Hide resolved

danielinux7 requested a review from pedberg-icu August 13, 2021 17:27

CLDR-14954 Add Abkhazian locale to CLDR

cd2de86

See #1402

srl295 approved these changes Aug 13, 2021

View reviewed changes

srl295 self-assigned this Aug 13, 2021

srl295 merged commit 0e1341e into unicode-org:master Aug 16, 2021

danielinux7 mentioned this pull request Mar 23, 2022

[1-тәи аҩаӡара] CLDR danielinux7/anana#14

Open

2 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

CLDR-14954 Add Abkhazian locale to CLDR #1402

CLDR-14954 Add Abkhazian locale to CLDR #1402

danielinux7 commented Aug 9, 2021 •

edited

Loading

jira-pull-request-webhook bot commented Aug 9, 2021

srl295 commented Aug 10, 2021

jira-pull-request-webhook bot commented Aug 11, 2021

danielinux7 commented Aug 11, 2021 •

edited

Loading

jira-pull-request-webhook bot commented Aug 11, 2021

srl295 Aug 11, 2021

srl295 Aug 11, 2021

srl295 Aug 13, 2021

danielinux7 Aug 13, 2021

srl295 Aug 11, 2021

jira-pull-request-webhook bot commented Aug 11, 2021

jira-pull-request-webhook bot commented Aug 11, 2021

srl295 left a comment

srl295 left a comment

danielinux7 commented Aug 11, 2021 •

edited

Loading

srl295 commented Aug 11, 2021

danielinux7 commented Aug 11, 2021

srl295 commented Aug 11, 2021

jira-pull-request-webhook bot commented Aug 11, 2021

jira-pull-request-webhook bot commented Aug 11, 2021

danielinux7 commented Aug 11, 2021

jira-pull-request-webhook bot commented Aug 13, 2021

jira-pull-request-webhook bot commented Aug 13, 2021

danielinux7 commented Aug 13, 2021

srl295 commented Aug 13, 2021

jira-pull-request-webhook bot commented Aug 13, 2021

danielinux7 commented Aug 13, 2021

srl295 commented Aug 13, 2021

srl295 commented Aug 13, 2021

pedberg-icu commented Sep 28, 2021

CLDR-14954 Add Abkhazian locale to CLDR #1402

CLDR-14954 Add Abkhazian locale to CLDR #1402

Conversation

danielinux7 commented Aug 9, 2021 • edited Loading

jira-pull-request-webhook bot commented Aug 9, 2021

srl295 commented Aug 10, 2021

jira-pull-request-webhook bot commented Aug 11, 2021

danielinux7 commented Aug 11, 2021 • edited Loading

jira-pull-request-webhook bot commented Aug 11, 2021

srl295 Aug 11, 2021

Choose a reason for hiding this comment

srl295 Aug 11, 2021

Choose a reason for hiding this comment

srl295 Aug 13, 2021

Choose a reason for hiding this comment

danielinux7 Aug 13, 2021

Choose a reason for hiding this comment

srl295 Aug 11, 2021

Choose a reason for hiding this comment

jira-pull-request-webhook bot commented Aug 11, 2021

jira-pull-request-webhook bot commented Aug 11, 2021

srl295 left a comment

Choose a reason for hiding this comment

srl295 left a comment

Choose a reason for hiding this comment

danielinux7 commented Aug 11, 2021 • edited Loading

srl295 commented Aug 11, 2021

danielinux7 commented Aug 11, 2021

srl295 commented Aug 11, 2021

jira-pull-request-webhook bot commented Aug 11, 2021

jira-pull-request-webhook bot commented Aug 11, 2021

danielinux7 commented Aug 11, 2021

jira-pull-request-webhook bot commented Aug 13, 2021

jira-pull-request-webhook bot commented Aug 13, 2021

danielinux7 commented Aug 13, 2021

srl295 commented Aug 13, 2021

jira-pull-request-webhook bot commented Aug 13, 2021

danielinux7 commented Aug 13, 2021

srl295 commented Aug 13, 2021

srl295 commented Aug 13, 2021

pedberg-icu commented Sep 28, 2021

danielinux7 commented Aug 9, 2021 •

edited

Loading

danielinux7 commented Aug 11, 2021 •

edited

Loading

danielinux7 commented Aug 11, 2021 •

edited

Loading