Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CLDR-15113 json: fix repeat keys in dateTime #1552

Merged

Conversation

srl295
Copy link
Member

@srl295 srl295 commented Oct 20, 2021

CLDR-15113

  • This PR completes the ticket.

Updated format. The "-datetimeSkeleton" part MAY change later.

            "dateFormats": {
              "full": "EEEE, MMMM d, y G",
              "full-datetimeSkeleton": "GyMMMMEEEEd",
              "long": "MMMM d, y G",
              "long-datetimeSkeleton": "GyMMMMd",
              "medium": "MMM d, y G",
              "medium-datetimeSkeleton": "GyMMMd",
              "short": "M/d/y GGGGG",
              "short-datetimeSkeleton": "GGGGGyMd"

- move 'datetimeSkeleton' elements to for eample 'full-datetimeSkeleton'
- does NOT address all dup keys, see CLDR-14717
@srl295 srl295 requested a review from sffc October 20, 2021 20:14
@srl295 srl295 self-assigned this Oct 20, 2021
@srl295 srl295 mentioned this pull request Oct 20, 2021
1 task
Copy link
Member

@sffc sffc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

If you can tag a new CLDR JSON release, I will try it in ICU4X

@srl295 srl295 merged commit f94f8a5 into unicode-org:maint/maint-40 Oct 20, 2021
@srl295 srl295 deleted the cldr-15113/json-nodupdates branch October 20, 2021 20:38
@macchiati
Copy link
Member

We should discuss the format of JSON more when we get a chance. I think the following would be a bit cleaner, for example.

Also, in the migration section you should outline what changes have happened. (And have a disclaimer that the format may change across versions. We should also talk later about the level of stability we want.)

"dateFormats": {
"full": "EEEE, MMMM d, y G",
"long": "MMMM d, y G",
"medium": "MMM d, y G",
"short": "M/d/y GGGGG",
}
"dateSkeletons": {
"full": "GyMMMMEEEEd",
"long": "GyMMMMd",
"medium": "GyMMMd",
"short": "GGGGGyMd"
}

@sffc
Copy link
Member

sffc commented Oct 20, 2021

Yeah, we should discuss the format further in CLDR-14717. However, the change proposed is best for this point in the release cycle because Mark's suggestion would result in the JSON paths changing for clients who expect data at the old paths.

@srl295
Copy link
Member Author

srl295 commented Oct 20, 2021

@macchiati yes, that's a better format, but very hard to do with a stream output.

@srl295
Copy link
Member Author

srl295 commented Oct 20, 2021

@macchiati I've updated the cldr 40 release note. thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants