Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CLDR-11585 Mavenize #21

Closed
wants to merge 8 commits into from
Closed

CLDR-11585 Mavenize #21

wants to merge 8 commits into from

Conversation

srl295
Copy link
Member

@srl295 srl295 commented May 21, 2019

CLDR-11585

Switch to maven.

  • utilities.jar is still a (deprecated) local .jar - it should live in maven.
  • no unit tests yet
  • not running the data build yet
  • very few files remain in LFS
  • TODO SurveyTool
  • utilities.jar is an open issue

@srl295 srl295 self-assigned this May 21, 2019
@srl295 srl295 changed the title Mavenize CLDR-11585 Mavenize May 21, 2019
@srl295 srl295 marked this pull request as ready for review May 22, 2019 23:52
@srl295
Copy link
Member Author

srl295 commented May 22, 2019

not really ready for review, but i'd like to get it to start building.

@srl295 srl295 closed this May 23, 2019
@srl295 srl295 reopened this May 23, 2019
macchiati
macchiati previously approved these changes May 28, 2019
Copy link
Member

@macchiati macchiati left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I know little about Maven, so just trusting that you've done the right thing!

@srl295
Copy link
Member Author

srl295 commented May 28, 2019

@macchiati thanks. This is going to be very disruptive to existing branches (all Java code gets renamed) so will need to be scheduled carefully.

@srl295
Copy link
Member Author

srl295 commented Jun 26, 2019

Let's try to restart this "later"…  we might want to mavenize just one part (the ST) first.

@srl295
Copy link
Member Author

srl295 commented Oct 30, 2019

=> #126

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants