Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CLDR-17416 v45 brs: spec link check #3634

Merged
merged 2 commits into from
Apr 16, 2024

Conversation

srl295
Copy link
Member

@srl295 srl295 commented Apr 15, 2024

  • linguistics-ontology.org/gold is no longer available, changed to archive.org links
  • other fixes

CLDR-17416

  • This PR completes the ticket.

ALLOW_MANY_COMMITS=true

@srl295 srl295 self-assigned this Apr 15, 2024
- linguistics-ontology.org/gold is no longer available, changed to archive.org links
- other fixes
@srl295 srl295 force-pushed the cldr-17416/v45brs/linkcheck branch from db4f6fa to b7c3fff Compare April 15, 2024 17:35
@jira-pull-request-webhook
Copy link

Hooray! The files in the branch are the same across the force-push. 😃

~ Your Friendly Jira-GitHub PR Checker Bot

@srl295 srl295 requested review from macchiati, pedberg-icu, AEApple and a team April 15, 2024 17:35
pedberg-icu
pedberg-icu previously approved these changes Apr 15, 2024
AEApple
AEApple previously approved these changes Apr 15, 2024
docs/ldml/tr35-general.md Outdated Show resolved Hide resolved
Copy link
Member

@macchiati macchiati left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Other than that, seems good. Was this the w3c link checker?

@macchiati
Copy link
Member

Hmmm. I just ran the w3c linkchecker on the main file, and it had some additional problems:

error Line: 1009 https://www.unicode.org/reports/tr35/tr35-72/tr35.html
Status: 404 Not Found
The link is broken. Double-check that you have not made any typo, or mistake in copy-pasting. If the link points to a resource that no longer exists, you may want to remove or fix the link.

error Line: 5380 https://cldr-smoke.unicode.org/spec/main/ldml/unit-prefixes
Status: 404 Not Found
The link is broken. Double-check that you have not made any typo, or mistake in copy-pasting. If the link points to a resource that no longer exists, you may want to remove or fix the link.

error Line: 1033 https://www.unicode.org/cldr/dtd/45/
Status: 302 -> 404 Not Found
The link is broken. Double-check that you have not made any typo, or mistake in copy-pasting. If the link points to a resource that no longer exists, you may want to remove or fix the link.

error Line: 5200 https://www.iso.org/obp/ui/
Status: 200 (no message)
Some of the links to this resource point to broken URI fragments (such as index.html#fragment).

Broken fragments:
https://www.iso.org/obp/ui/#search (line 5200)
info Line: 1001 mailto:markdavis@google.com
Status: (N/A) Access to 'mailto' URIs has been disabled
Accessing links with this URI scheme has been disabled in link checker.

@srl295
Copy link
Member Author

srl295 commented Apr 15, 2024

Other than that, seems good. Was this the w3c link checker?

no, lychee

@srl295
Copy link
Member Author

srl295 commented Apr 15, 2024

Hmmm. I just ran the w3c linkchecker on the main file, and it had some additional problems:

error Line: 1009 https://www.unicode.org/reports/tr35/tr35-72/tr35.html Status: 404 Not Found The link is broken. Double-check that you have not made any typo, or mistake in copy-pasting. If the link points to a resource that no longer exists, you may want to remove or fix the link.

this one will exist when we publish

error Line: 5380 https://cldr-smoke.unicode.org/spec/main/ldml/unit-prefixes Status: 404 Not Found The link is broken. Double-check that you have not made any typo, or mistake in copy-pasting. If the link points to a resource that no longer exists, you may want to remove or fix the link.

fixed in this PR

error Line: 1033 https://www.unicode.org/cldr/dtd/45/ Status: 302 -> 404 Not Found The link is broken. Double-check that you have not made any typo, or mistake in copy-pasting. If the link points to a resource that no longer exists, you may want to remove or fix the link.

will exist when we publish

error Line: 5200 https://www.iso.org/obp/ui/ Status: 200 (no message) Some of the links to this resource point to broken URI fragments (such as index.html#fragment).

this is a link to a resource with in the SPA, the page loads fine

Broken fragments: https://www.iso.org/obp/ui/#search (line 5200) info Line: 1001 mailto:markdavis@google.com Status: (N/A) Access to 'mailto' URIs has been disabled Accessing links with this URI scheme has been disabled in link checker.

will have to email them to see if that link works!

Co-authored-by: Mark Davis <mark@unicode.org>
@srl295
Copy link
Member Author

srl295 commented Apr 16, 2024

Can i get a re review?

@macchiati
Copy link
Member

By the following comment:

this one will exist when we publish
do you mean:
this one will be fixed once we publish

@srl295 srl295 merged commit 44a4d94 into unicode-org:maint/maint-45 Apr 16, 2024
7 checks passed
@srl295 srl295 deleted the cldr-17416/v45brs/linkcheck branch April 16, 2024 01:21
@srl295
Copy link
Member Author

srl295 commented Apr 16, 2024

By the following comment:

this one will exist when we publish

do you mean:

this one will be fixed once we publish

The resource identified by the url will exist when we publish.

pedberg-icu pushed a commit to pedberg-icu/cldr that referenced this pull request Apr 22, 2024
pedberg-icu pushed a commit that referenced this pull request Apr 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
4 participants