Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CLDR-16101 Change Error Subtype to read from Google Sheets #3649

Merged
merged 2 commits into from
Apr 29, 2024

Conversation

srl295
Copy link
Member

@srl295 srl295 commented Apr 19, 2024

CLDR-16101

ALLOW_MANY_COMMITS=true

@srl295 srl295 self-assigned this Apr 19, 2024
Copy link
Member

@macchiati macchiati left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

BTW, I filed a ticket to make the subtypes be explicitly either errors or warnings, but not both. I think that would make it much clearer.

@srl295 srl295 marked this pull request as ready for review April 20, 2024 00:56
@srl295 srl295 marked this pull request as draft April 20, 2024 00:57
- config parameter CLDR_SUBTYPE_URL for configuring subtype map
- fix reloading page
@jira-pull-request-webhook
Copy link

Notice: the branch changed across the force-push!

  • tools/cldr-apps/js/src/esm/cldrText.mjs is no longer changed in the branch
  • tools/cldr-apps/src/main/java/org/unicode/cldr/web/api/ReportAPI.java is no longer changed in the branch
  • tools/cldr-apps/src/main/java/org/unicode/cldr/web/SubtypeToURLMap.java is different
  • tools/cldr-code/src/main/java/org/unicode/cldr/test/CheckCLDR.java is no longer changed in the branch
  • tools/cldr-code/src/main/java/org/unicode/cldr/test/ConsoleCheckCLDR.java is no longer changed in the branch
  • tools/cldr-code/src/main/java/org/unicode/cldr/tool/Chart.java is no longer changed in the branch
  • tools/cldr-code/src/main/java/org/unicode/cldr/tool/ChartSupplemental.java is no longer changed in the branch
  • tools/cldr-code/src/main/java/org/unicode/cldr/util/VettingViewer.java is no longer changed in the branch
  • tools/cldr-code/src/main/java/org/unicode/cldr/util/VoterReportStatus.java is no longer changed in the branch

View Diff Across Force-Push

~ Your Friendly Jira-GitHub PR Checker Bot

@srl295 srl295 changed the title CLDR-16101 fix error subtype page CLDR-16101 Change Error Subtype to read from Google Sheets Apr 26, 2024
- read from sheets instead of parsing HTML
- update error type admin panel
@jira-pull-request-webhook
Copy link

Notice: the branch changed across the force-push!

  • tools/cldr-apps/src/main/java/org/unicode/cldr/web/ErrorSubtypes.java is different
  • tools/cldr-apps/src/main/java/org/unicode/cldr/web/SubtypeToURLMap.java is different
  • tools/cldr-apps/src/test/java/org/unicode/cldr/util/TestCLDRLinks.java is now changed in the branch

View Diff Across Force-Push

~ Your Friendly Jira-GitHub PR Checker Bot

@srl295 srl295 marked this pull request as ready for review April 27, 2024 00:01
Copy link
Member

@macchiati macchiati left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Question: would it be hard to move the "read a spreadsheet" utility into the .util directory? I could see that being very useful for making lots of stuff more dynamic.

@srl295
Copy link
Member Author

srl295 commented Apr 29, 2024

Looks good. Question: would it be hard to move the "read a spreadsheet" utility into the .util directory?

This doesn't download, but it does access the data. It reads it into a cache directory in a manner of speaking.

I could see that being very useful for making lots of stuff more dynamic.

yes, although the authentication bit is interesting. This mode is suitable for a service system, if you are envisioning a command line utility it would be easier to set it up to have the user login locally (slightly different setup).

@srl295 srl295 merged commit f857541 into unicode-org:main Apr 29, 2024
11 checks passed
@srl295 srl295 deleted the cldr-16101/subtype branch April 29, 2024 17:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants