Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CLDR-13771 workaround ansible-lint failing #729

Merged
merged 1 commit into from
Sep 23, 2020

Conversation

srl295
Copy link
Member

@srl295 srl295 commented Sep 23, 2020

@srl295 srl295 self-assigned this Sep 23, 2020
@srl295
Copy link
Member Author

srl295 commented Sep 23, 2020

  • also, lint all playbooks
  • also, use a specific hash of the ansible action, since it's not otherwise versioned.

@srl295
Copy link
Member Author

srl295 commented Sep 23, 2020

^ seems to work. This ansible lint job passed, where others have been failing for the past few hours.

FYI @btangmu @macchiati in case you see 'ansible lint' failures, this fixes it.

@srl295
Copy link
Member Author

srl295 commented Sep 23, 2020

failure was:

+ override_python_packages
+ [[ -n ansible==2.9
ansible-lint==4.2.0
 ]]
+ pip install ansible==2.9 ansible-lint==4.2.0
WARNING: The directory '/github/home/.cache/pip' or its parent directory is not owned or is not writable by the current user. The cache has been disabled. Check the permissions and owner of that directory. If executing pip with sudo, you may want sudo's -H flag.
Collecting ansible==2.9
  Downloading ansible-2.9.0.tar.gz (14.1 MB)
Collecting ansible-lint==4.2.0
  Downloading ansible_lint-4.2.0-py2.py3-none-any.whl (57 kB)

Copy link
Contributor

@echeran echeran left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Seems straightforward enough, and this is a good change -- just using a snapshot of the action that effectively fixes in place the version of Ansible being used. FWIW, it looks like they pushed tags for the GH action.

@srl295
Copy link
Member Author

srl295 commented Sep 23, 2020

LGTM. Seems straightforward enough, and this is a good change -- just using a snapshot of the action that effectively fixes in place the version of Ansible being used. FWIW, it looks like they pushed tags for the GH action.

yes, but 83 commits since that tag ansible/ansible-lint-action@v4.1.0...master

Copy link
Member

@btangmu btangmu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ideally there might be a comment here clarifying the magic number, linking to https://github.com/ansible/ansible-lint-action/tree/6c8c14186662e43effbe39a678950896a46799ad

Maybe add that later, if this isn't replaced soon

@srl295 srl295 merged commit 1fb7d3b into unicode-org:master Sep 23, 2020
@srl295 srl295 deleted the fixlint-13771 branch September 23, 2020 21:19
srl295 added a commit to srl295/cldr that referenced this pull request Sep 24, 2020
- do not specify the maven central URL but let it default
- update some action versions
- do not run tests twice!

- also, add a comment explaining a line in the ansible-lint.yml
(from CLDR-13771 workaround ansible-lint failing (unicode-org#729) )
srl295 added a commit to srl295/cldr that referenced this pull request Sep 24, 2020
- cache maven dependencies for build speedup and reliability
- do not specify the maven central URL but let it default
- update some action versions
- do not run tests twice!

- also, add a comment explaining a line in the ansible-lint.yml
(from CLDR-13771 workaround ansible-lint failing (unicode-org#729) )
pedberg-icu pushed a commit that referenced this pull request Sep 24, 2020
- see ansible-collections/community.kubernetes#135 (comment)
- workaround by not setting a version

(cherry picked from commit 1fb7d3b)
srl295 added a commit that referenced this pull request Sep 25, 2020
- cache maven dependencies for build speedup and reliability
- do not specify the maven central URL but let it default
- update some action versions
- do not run tests twice!

- also, add a comment explaining a line in the ansible-lint.yml
(from CLDR-13771 workaround ansible-lint failing (#729) )
pedberg-icu pushed a commit that referenced this pull request Oct 9, 2020
- cache maven dependencies for build speedup and reliability
- do not specify the maven central URL but let it default
- update some action versions
- do not run tests twice!

- also, add a comment explaining a line in the ansible-lint.yml
(from CLDR-13771 workaround ansible-lint failing (#729) )

(cherry picked from commit 880b495)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants