-
Notifications
You must be signed in to change notification settings - Fork 367
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CLDR-13771 workaround ansible-lint failing #729
Conversation
- see ansible-collections/community.kubernetes#135 (comment) - workaround by not setting a version
|
^ seems to work. This ansible lint job passed, where others have been failing for the past few hours. FYI @btangmu @macchiati in case you see 'ansible lint' failures, this fixes it. |
failure was:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Seems straightforward enough, and this is a good change -- just using a snapshot of the action that effectively fixes in place the version of Ansible being used. FWIW, it looks like they pushed tags for the GH action.
yes, but 83 commits since that tag ansible/ansible-lint-action@v4.1.0...master |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ideally there might be a comment here clarifying the magic number, linking to https://github.com/ansible/ansible-lint-action/tree/6c8c14186662e43effbe39a678950896a46799ad
Maybe add that later, if this isn't replaced soon
- do not specify the maven central URL but let it default - update some action versions - do not run tests twice! - also, add a comment explaining a line in the ansible-lint.yml (from CLDR-13771 workaround ansible-lint failing (unicode-org#729) )
- cache maven dependencies for build speedup and reliability - do not specify the maven central URL but let it default - update some action versions - do not run tests twice! - also, add a comment explaining a line in the ansible-lint.yml (from CLDR-13771 workaround ansible-lint failing (unicode-org#729) )
- see ansible-collections/community.kubernetes#135 (comment) - workaround by not setting a version (cherry picked from commit 1fb7d3b)
- cache maven dependencies for build speedup and reliability - do not specify the maven central URL but let it default - update some action versions - do not run tests twice! - also, add a comment explaining a line in the ansible-lint.yml (from CLDR-13771 workaround ansible-lint failing (#729) )
- cache maven dependencies for build speedup and reliability - do not specify the maven central URL but let it default - update some action versions - do not run tests twice! - also, add a comment explaining a line in the ansible-lint.yml (from CLDR-13771 workaround ansible-lint failing (#729) ) (cherry picked from commit 880b495)
CLDR-13771