CLDR-14212 Update GitHub actions to @vx vs @vx.y.z #813
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
srl295
changed the title
- Background: https://github.community/t/version-numbering-for-actions/16307/4 - Specific issue: actions/setup-java#104 (comment) actions/setup-java@v1.4.2 was creating warning messages about set-env, needed to switch to v1.4.3. Instead, all actions now use @v1 or @v2, which points to a branch.
|
Hooray! The files in the branch are the same across the force-push. 😃 ~ Your Friendly Jira-GitHub PR Checker Bot |
|
This is the cause of the 'warnings' in the setup-java phases. |
echeran
approved these changes
Oct 23, 2020
There was a problem hiding this comment.
LGTM. Thanks for the links to the specific details on how GH Actions versioning is supposed to work. It makes sense that the onus is on the action maintainer to keep the latest major version alias pointed to the latest release, since each version is really defined just as the name of a git ref (branch/tag) in the action's git repo.
srl295
requested review from
hagbard,
macchiati,
pedberg-icu and
sffc
and removed request for
sffc
macchiati
approved these changes
Oct 30, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CLDR-14212
actions/setup-java@v1.4.2 was creating warning messages about set-env,
needed to switch to v1.4.3. Instead, all actions now use @v1 or @v2, which points to a
branch.