CLDR-11059 fix cldr-json licensing #972
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
srl295
commented
Jan 26, 2021
| @@ -912,6 +913,7 @@ public void writeBowerJson(String outputDir, String packageName) throws IOExcept | |||
| ignorePaths.add(new JsonPrimitive(".gitattributes")); | |||
| ignorePaths.add(new JsonPrimitive("README.md")); | |||
| obj.add("ignore", ignorePaths); | |||
| obj.addProperty("license", CLDRURLS.UNICODE_SPDX); | |||
There was a problem hiding this comment.
this is the fix for bower
macchiati
previously approved these changes
Jan 27, 2021
srl295
force-pushed
the
cldr-11059-json
branch
from
b3175f3
to
d47f8de
Compare
|
Notice: the branch changed across the force-push!
~ Your Friendly Jira-GitHub PR Checker Bot |
srl295
force-pushed
the
cldr-11059-json
branch
from
d47f8de
to
b3175f3
Compare
|
Notice: the branch changed across the force-push!
~ Your Friendly Jira-GitHub PR Checker Bot |
srl295
force-pushed
the
cldr-11059-json
branch
from
b3175f3
to
d47f8de
Compare
|
Notice: the branch changed across the force-push!
~ Your Friendly Jira-GitHub PR Checker Bot |
|
@macchiati sorry, i missed your approval! I had another change (to fix the versioning) |
2 tasks
srl295
added a commit
to unicode-org/cldr-json
that referenced
this pull request
Jan 27, 2021
CLDR tool source: unicode-org/cldr#972 Note, 'Currie' was dropped somehow with this generation, so I excluded that: unicode-org/cldr#970 (comment)
macchiati
previously approved these changes
Jan 27, 2021
|
The glucose thing causes a test failure. |
- Allow JSON cldrVersion to be affected by -V command line option for overriding
srl295
force-pushed
the
cldr-11059-json
branch
from
d47f8de
to
2b083b8
Compare
|
Notice: the branch changed across the force-push!
~ Your Friendly Jira-GitHub PR Checker Bot |
srl295
added a commit
to unicode-org/cldr-json
that referenced
this pull request
Jan 27, 2021
* cldr 38.1 beta update v38.1.0-BETA (tagged "beta" in npm) generated from cldr-staging 1acbe10c8af48794cbe9966cb9a6cea92cee6004 generated from cldr tools f7d6d55ca3073b209d3bf2dd9fcf15d28c259e16 * improve build script cldr-generate-json.sh * create zipfiles * generate cldr-segments-full and also annotations * build scripts WIP (-V temporarily dropped) * Update reflecting CLDR-14313 fixes Reflecting commit c0060510ce98a43f1c8c8541afe48f3cbf442632 on CLDR (see unicode-org/cldr#888 for its destination) Summary of changes: - These items are now arrays instead of strings: - supplemental/calendarPreferenceData - supplemental/weekData (now grouped by territory) - Previously MISSING data now added - cldr-core/dayPeriods.json: dayPeriodRuleSet-type-selection" - cldr-core/units.json: unitConstants, unitQuantities - cldr-core/unitsMetadata.json: unit deprecations * segments packaging missed * script improvements: MATCH * warn if you have a local-config.sh * getting ready to build 38.1.0-BETA4 * update packaging 38.1.0-BETA4 * update license and versioning per CLDR-11059 CLDR tool source: unicode-org/cldr#972 Note, 'Currie' was dropped somehow with this generation, so I excluded that: unicode-org/cldr#970 (comment) * bump proposed tag to 38.1.0 * version regen to 38.1.0
srl295
changed the title
|
@macchiati one more review? I backed out the MapComparator changes, will do that in a separate PR |
macchiati
approved these changes
Jan 27, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CLDR-11059
Without the DtdData change, CLDR 39 is unable to read CLDR 38.1 staging data, crashes with "Missing Map Comparator Values …
concentr-milligram-per-deciliter…"