Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CLDR-14232 add deprecated units to the DtdData comparator #986

Merged
merged 1 commit into from Jan 27, 2021
Merged

CLDR-14232 add deprecated units to the DtdData comparator #986

merged 1 commit into from Jan 27, 2021

Conversation

macchiati
Copy link
Member

Checklist

@macchiati macchiati requested a review from srl295 January 27, 2021 19:17
srl295
srl295 approved these changes Jan 27, 2021
View reviewed changes
Copy link
Member

@srl295 srl295 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

obviates #983

LGTM… is there an issue for making the array data (or metadata) driven? would that have helped solve this?

@macchiati
Copy link
Member Author

obviates #983

LGTM… is there an issue for making the array data (or metadata) driven? would that have helped solve this?

I filed https://unicode-org.atlassian.net/browse/CLDR-14452 about that.

@macchiati macchiati merged commit ea17335 into unicode-org:master Jan 27, 2021
@macchiati macchiati deleted the CLDR-14232-Add-deprecated-units-to-the-DtdData-comparator branch January 27, 2021 19:49
@srl295 srl295 mentioned this pull request Jan 27, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@srl295 srl295 srl295 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@macchiati @srl295