Adding coll_nonignorable_short testing #94
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sffc
reviewed
Aug 18, 2023
mosuem
reviewed
Aug 23, 2023
|
Ready for another review. This now works in dart_web, node, and icu4x (mostly) for over 380K test samples. |
mosuem
approved these changes
Sep 6, 2023
|
OK, folks. Please take a look. This has a lot of changes in the testing data for collation. The quick tests have been simplified and also are brought up to work with ICU73 data. |
|
Going ahead to merge this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds collation for node, comparing with default parameters. There are still test failures that need to be explained.
And rust doesn't yet implement this option. Note that this could be redone using a runtime parameter to the collation executor rather than separate collation .js code.