Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ICU-21958 Update Collation Demo index.html for ICU72.1 #34

Merged
merged 2 commits into from
Nov 9, 2022
Merged

ICU-21958 Update Collation Demo index.html for ICU72.1 #34

merged 2 commits into from
Nov 9, 2022

Conversation

sven-oly
Copy link
Contributor

@sven-oly sven-oly commented Nov 4, 2022

Updates with new CLDR and ICU data

markusicu
markusicu reviewed Nov 5, 2022
View reviewed changes
Copy link
Member

@markusicu markusicu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

one snafu, otherwise lgtm

webdemo/collation/index.html Outdated Show resolved Hide resolved
@sven-oly @markusicu
Update webdemo/collation/index.html
8e82210 
Co-authored-by: Markus Scherer <markus.icu@gmail.com>
markusicu
markusicu approved these changes Nov 9, 2022
View reviewed changes
Copy link
Member

@markusicu markusicu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm tnx

Please squash-and-merge, and please make sure that the squash commit message starts with the ICU ticket number. (Especially since the second commit here does not have that.)

@sven-oly sven-oly merged commit 1d7801d into unicode-org:main Nov 9, 2022
@sven-oly sven-oly deleted the CollationDemo72.1 branch May 9, 2023 21:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@markusicu markusicu markusicu approved these changes

Assignees

@markusicu markusicu

Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@sven-oly @markusicu