Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ICU-21546 Update ICU4C API reference docs for 69.1 #25

Closed
wants to merge 12 commits into from

Conversation

sven-oly
Copy link
Contributor

@sven-oly sven-oly commented Apr 8, 2021

No description provided.

@sven-oly sven-oly requested a review from markusicu April 8, 2021 04:10
@sven-oly sven-oly requested a review from hugovdm April 8, 2021 04:37
@sven-oly
Copy link
Contributor Author

sven-oly commented Apr 8, 2021

Second commit removes unneeded .zip.

@hugovdm
Copy link
Contributor

hugovdm commented Apr 8, 2021

This isn't currently serving at https://sven-oly.github.io/icu-docs/ - fwiw I pushed to my repo, docs are building, should soon be serving commit eb55b8c at this URL: https://hugovdm.github.io/icu-docs/

@hugovdm
Copy link
Contributor

hugovdm commented Apr 8, 2021

Can you merge upstream/main and edit README.md? Or are you happy if I push my merge commit and README.md update to your branch?

@sven-oly
Copy link
Contributor Author

sven-oly commented Apr 8, 2021

Hi Hugo, please go ahead and merge as you see fit.

I've updated my README.md to point to ICU69.1 release.

@sven-oly
Copy link
Contributor Author

sven-oly commented Apr 8, 2021

I think this is now resolved. https://sven-oly.github.io/icu-docs/ now is publicly available.

Copy link
Member

@markusicu markusicu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

rslgtm please squash

README.md Outdated
| Released | [icu4c 68.1](./apidoc/released/icu4c) | [icu4j 69.1](./apidoc/released/icu4j) |
| Dev | [icu4c](./apidoc/dev/icu4c) | [icu4j](./apidoc/dev/icu4j) |
| Released | [icu4c 69.1](./apidoc/released/icu4c) | [icu4j 69.1](./apidoc/released/icu4j) |
| Dev | [icu4c](./apidoc/dev/icu4c) | [icu4j](./apidoc/dev/icu4j) |
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It would be nice to revert this line to exactly what it was before.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done.

@sven-oly sven-oly closed this Apr 8, 2021
Copy link
Contributor

@hugovdm hugovdm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FYI: one can also squash to a single commit by simply resetting the branch head to the commit where one wants to squash, then commit all the changes together / at once.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants