Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ICU-21081 Make U_ASSERT C++14 compatible #1132

Merged
merged 1 commit into from May 9, 2020
Merged

ICU-21081 Make U_ASSERT C++14 compatible #1132

merged 1 commit into from May 9, 2020

Conversation

sffc
Copy link
Member

@sffc sffc commented Apr 25, 2020 •
edited

@jefgen How/where would you recommend adding a C++14 build bot?

Checklist

@sffc sffc requested review from roubert and jefgen April 25, 2020 00:24
@jefgen
Copy link
Member

jefgen commented Apr 27, 2020 •
edited

How/where would you recommend adding a C++14 build bot?

Hmm, I think we could likely add another build bot for it -- though we should probably also update to Ubuntu 18.04 as well for it. Let me see...

jefgen
jefgen approved these changes Apr 27, 2020
View reviewed changes
Copy link
Member

@jefgen jefgen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@jefgen jefgen mentioned this pull request Apr 27, 2020
Merged
5 tasks
@jefgen jefgen merged commit 715d254 into master May 9, 2020
@sffc sffc deleted the sffc-patch-1 branch May 12, 2020 17:37
@sffc sffc mentioned this pull request May 12, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@roubert roubert roubert approved these changes

@jefgen jefgen jefgen approved these changes

Assignees

@jefgen jefgen

Labels
None yet
Projects
None yet
Milestone
No milestone
3 participants
@sffc @jefgen @roubert