ICU-13786 Fix addLikelySubtags/minimizeSubtags #1140
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
FrankYFTang
force-pushed
the
ICU-13786-addLikelySubtags
branch
from
f52b74f
to
e93c2c5
Compare
|
Notice: the branch changed across the force-push!
~ Your Friendly Jira-GitHub PR Checker Bot |
FrankYFTang
force-pushed
the
ICU-13786-addLikelySubtags
branch
from
e93c2c5
to
6f68fc7
Compare
|
Notice: the branch changed across the force-push!
~ Your Friendly Jira-GitHub PR Checker Bot |
roubert
previously requested changes
Apr 30, 2020
FrankYFTang
commented
Apr 30, 2020
|
PTAL I change the name of "outSink" back to "sink" but keep my other rename of "sink" of local variable as baseSink, tagSink and so on so it is clear which one is the local one and which one is the 'sink' which intend for the output. I also change the nullptr back to NULL as requested by roubert. |
|
ping |
1 similar comment
|
ping |
FrankYFTang
force-pushed
the
ICU-13786-addLikelySubtags
branch
from
19a2496
to
acbdd2e
Compare
|
Hooray! The files in the branch are the same across the force-push. 😃 ~ Your Friendly Jira-GitHub PR Checker Bot |
FrankYFTang
dismissed
roubert’s stale review
cannot figure out which one is not addressed in the newer version
kishiguro
pushed a commit
to kishiguro/icu
that referenced
this pull request
Jun 16, 2020
ICU-13786 Fix addLikelySubtags/minimizeSubtags #1140 Bug: https://unicode-org.atlassian.net/browse/ICU-13786 PR: unicode-org/icu#1140 Bug: v8:10448 Change-Id: Id5e8b0037bbe76941fa89f7564d49cf27a990b2e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/deps/icu/+/2231777 Reviewed-by: Jungshik Shin <jshin@chromium.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://github.com/tc39/test262/blob/master/test/intl402/Locale/prototype/minimize/removing-likely-subtags-first-adds-likely-subtags.js
a) Make _ulocimp_addLikelySubtags propagate matching error so
minimizeSubtags can just return the no matching case unchanged.
b) rename the sink variable to outSink and local sink variables to
avoid confusion and mistake
c) Correct the implementation of minimizeSubtags by using the lang,
region, script of the "max" instead of the localeID in the algorithm.
Checklist