Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ICU-21295 Fix for Java version number overflow problem in 58 #1460

Closed
wants to merge 1 commit into from
Closed

ICU-21295 Fix for Java version number overflow problem in 58 #1460

wants to merge 1 commit into from

Commits on Nov 10, 2020

  1. ICU-21295 Fix for Java version number overflow problem 

    Merging the fix for ICU-21219 (PR unicode-org#1245) to ICU 58.

Internal API VersionInfo.javaVersion() maps Java version number to  4 integer fields. Each field must be up to 255. However, recent OpenJDK 8 update exceed this range.

Luckily, we have only one reference in our code base for checking Java version. CharsetUTF16 uses maxBytePerChar = 4 for Java 5 and older, maxBytePerChar = 2 for newer Java version. Because we no longer support Java 5 runtime, we don't need this conditional check.

We don't have any other uses of VersionInfo.javaVersion(). Java's version range is not what we can control, so I decided to delete the internal use only API completely.
    @yumaoka
    yumaoka committed Nov 10, 2020
    Configuration menu
    Copy the full SHA
    635d7a4 View commit details
    Browse the repository at this point in the history