Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ICU-21408 Prohibit alpha4 as language inside tlang. #1478

Merged
merged 1 commit into from Nov 24, 2020

Conversation

FrankYFTang
Copy link
Contributor

@FrankYFTang FrankYFTang commented Nov 19, 2020

Checklist

Copy link
Member

@markusicu markusicu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

but please also test (& fix if necessary) in Java

@FrankYFTang
Copy link
Contributor Author

Fixing java would be a lot of work because in C++ LocaleBuilder is based on the UTS35 grammar and parse -t- -u- and -x- and other extension . But in Java right now the ULocale.Builder is based on BCP47 grammar and parse -u- and -x- an other extension and does not parse -t- extension based on UTS35. Could I land this small fix for C++ first?

@markusicu
Copy link
Member

Could I land this small fix for C++ first?

yes, ok

Copy link
Member

@markusicu markusicu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@FrankYFTang FrankYFTang merged commit 0ab995e into unicode-org:master Nov 24, 2020
@FrankYFTang FrankYFTang deleted the ICU-21408-no-root branch November 24, 2020 22:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants