Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ICU-21406 canonicalize -T- extension #1491

Merged
merged 1 commit into from Dec 8, 2020
Merged

ICU-21406 canonicalize -T- extension #1491

merged 1 commit into from Dec 8, 2020

Conversation

FrankYFTang
Copy link
Contributor

  1. put tfield in alphabet order based on tkey
  2. canonicalize tlang
Checklist

@FrankYFTang
Copy link
Contributor Author

ping

markusicu
markusicu reviewed Dec 4, 2020
View reviewed changes
icu4c/source/common/locid.cpp Outdated Show resolved Hide resolved
icu4c/source/common/locid.cpp Outdated Show resolved Hide resolved
icu4c/source/common/locid.cpp Outdated Show resolved Hide resolved
icu4c/source/common/locid.cpp Outdated Show resolved Hide resolved
icu4c/source/common/locid.cpp Outdated Show resolved Hide resolved
icu4c/source/common/uloc_tag.cpp Outdated Show resolved Hide resolved
icu4j/main/classes/core/src/com/ibm/icu/util/ULocale.java Show resolved Hide resolved
icu4j/main/classes/core/src/com/ibm/icu/util/ULocale.java Show resolved Hide resolved
icu4j/main/classes/core/src/com/ibm/icu/util/ULocale.java Show resolved Hide resolved
icu4j/main/classes/core/src/com/ibm/icu/util/ULocale.java Show resolved Hide resolved
@FrankYFTang
Copy link
Contributor Author

PTAL

markusicu
markusicu reviewed Dec 7, 2020
View reviewed changes
Copy link
Member

@markusicu markusicu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

one more change (see comment), then please squash

icu4c/source/common/locid.cpp Outdated Show resolved Hide resolved
@FrankYFTang FrankYFTang force-pushed the ICU-21406-t-ext-canonical-wo-casing branch from fca51e2 to caa52e3 Compare December 8, 2020 00:04
@jira-pull-request-webhook
Copy link

Hooray! The files in the branch are the same across the force-push. 😃

~ Your Friendly Jira-GitHub PR Checker Bot

markusicu
markusicu approved these changes Dec 8, 2020
View reviewed changes
Copy link
Member

@markusicu markusicu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm tnx

@FrankYFTang FrankYFTang merged commit 5f8df0d into unicode-org:master Dec 8, 2020
@FrankYFTang FrankYFTang deleted the ICU-21406-t-ext-canonical-wo-casing branch December 8, 2020 05:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@markusicu markusicu markusicu approved these changes

@macchiati macchiati Awaiting requested review from macchiati

@yumaoka yumaoka Awaiting requested review from yumaoka

Assignees

@markusicu markusicu

Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@FrankYFTang @markusicu