Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ICU-21493 Add more rounding modes in ICU4C #1575

Merged
merged 1 commit into from
Feb 27, 2021
Merged

ICU-21493 Add more rounding modes in ICU4C #1575

merged 1 commit into from
Feb 27, 2021

Conversation

sffc
Copy link
Member

@sffc sffc commented Feb 12, 2021

Checklist

@sffc sffc requested a review from markusicu February 12, 2021 03:26
@sffc sffc mentioned this pull request Feb 12, 2021
Closed
markusicu
markusicu reviewed Feb 17, 2021
View reviewed changes
Copy link
Member

@markusicu markusicu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm but would prefer minor doc tweaks, see below
ok if you disagree

docs/userguide/format_parse/numbers/rounding-modes.md Outdated Show resolved Hide resolved
icu4c/source/i18n/unicode/unum.h Outdated Show resolved Hide resolved
icu4c/source/i18n/unicode/unum.h Outdated Show resolved Hide resolved
icu4c/source/i18n/unicode/unum.h Outdated Show resolved Hide resolved
@markusicu
Copy link
Member

FYI pending comments, from me and from yourself

@sffc sffc requested a review from markusicu February 25, 2021 02:49
markusicu
markusicu reviewed Feb 27, 2021
View reviewed changes
Copy link
Member

@markusicu markusicu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm pse squash

@jira-pull-request-webhook
Copy link

Hooray! The files in the branch are the same across the force-push. 😃

~ Your Friendly Jira-GitHub PR Checker Bot

@sffc sffc requested a review from markusicu February 27, 2021 09:02
markusicu
markusicu approved these changes Feb 27, 2021
View reviewed changes
Copy link
Member

@markusicu markusicu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@sffc sffc merged commit e8dfea9 into unicode-org:master Feb 27, 2021
@sffc sffc deleted the ICU-21493-modes branch February 27, 2021 18:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@markusicu markusicu markusicu approved these changes

Assignees

@markusicu markusicu

Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@sffc @markusicu