Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ICU-20186 Adding test for semicolon spacing in DecimalFormat. #184

Merged
merged 1 commit into from Nov 27, 2018
Merged

ICU-20186 Adding test for semicolon spacing in DecimalFormat. #184

merged 1 commit into from Nov 27, 2018

Conversation

sffc
Copy link
Member

@sffc sffc commented Oct 1, 2018

Checklist

@sffc
Copy link
Member Author

sffc commented Oct 23, 2018

Ping @macchiati

@sffc sffc requested a review from macchiati October 23, 2018 03:40
macchiati
macchiati approved these changes Nov 21, 2018
View reviewed changes
Copy link
Member

@macchiati macchiati left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. One question: is there at test for spaces at the start/end of the string also, eg

" 0.00 ; -0.00 "

@sffc
Copy link
Member Author

sffc commented Nov 27, 2018

Thanks. I will follow up with your comment in a new PR.

@sffc sffc merged commit 1e4a8d3 into unicode-org:master Nov 27, 2018
@sffc sffc deleted the ICU-20186 branch November 27, 2018 00:51
@sffc sffc mentioned this pull request Nov 27, 2018
Merged
5 tasks
@sffc
Copy link
Member Author

sffc commented Nov 27, 2018

Follow-up: #293

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@macchiati macchiati macchiati approved these changes

Assignees

@macchiati macchiati

Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@sffc @macchiati