Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ICU-22333 Exclude ExhaustivePersonNameFormatterTest also from releaseJ… #2425

Merged
merged 1 commit into from Apr 20, 2023
Merged

ICU-22333 Exclude ExhaustivePersonNameFormatterTest also from releaseJ… #2425

merged 1 commit into from Apr 20, 2023

Conversation

yumaoka
Copy link
Member

@yumaoka yumaoka commented Apr 13, 2023

…arCheck target.

Checklist
  • Required: Issue filed: https://unicode-org.atlassian.net/browse/ICU-22333
  • Required: The PR title must be prefixed with a JIRA Issue number.
  • Required: The PR description must include the link to the Jira Issue, for example by completing the URL in the first checklist item
  • Required: Each commit message must be prefixed with a JIRA Issue number.
  • Issue accepted (done by Technical Committee after discussion)
  • Tests included, if applicable
  • API docs and/or User Guide docs changed or added, if applicable

markusicu
markusicu approved these changes Apr 13, 2023
View reviewed changes
Copy link
Member

@markusicu markusicu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

rslgtm

@markusicu markusicu changed the title ICU-22333 Exclude EhaustivePersonNameFormatterTest also from releaseJ… ICU-22333 Exclude ExhaustivePersonNameFormatterTest also from releaseJ… Apr 14, 2023
@markusicu
Copy link
Member

FYI typo in the commit message; I just fixed it in the PR title. Ok if you check in as-is, or I can re-stamp after amending.

@markusicu
Copy link
Member

Why would the gcc-debug-build-and-test be getting killed after a little more than 4 minutes?

@markusicu
Copy link
Member

tests pass now, and @richgillam wrote in a ticket comment “your PR looked fine to me”

richgillam
richgillam approved these changes Apr 17, 2023
View reviewed changes
Copy link
Contributor

@richgillam richgillam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine to me. Thanks for making the change!

@yumaoka yumaoka merged commit 295f0f2 into unicode-org:main Apr 20, 2023
98 checks passed
@yumaoka yumaoka deleted the jarcheck-fix branch April 20, 2023 15:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@markusicu markusicu markusicu approved these changes

@richgillam richgillam richgillam approved these changes

Assignees

@markusicu markusicu

Labels
None yet
Projects
None yet
Milestone
No milestone
3 participants
@yumaoka @markusicu @richgillam