Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ICU-22392 Add, primary support for Haiku #2463

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

ICU-22392 Add, primary support for Haiku #2463

wants to merge 1 commit into from

Conversation

Begasus
Copy link

@Begasus Begasus commented May 14, 2023 •
edited by markusicu

Checklist
  • Required: Issue filed: https://unicode-org.atlassian.net/browse/ICU-22392
  • Required: The PR title must be prefixed with a JIRA Issue number.
  • Required: The PR description must include the link to the Jira Issue, for example by completing the URL in the first checklist item
  • Required: Each commit message must be prefixed with a JIRA Issue number.
  • Issue accepted (done by Technical Committee after discussion)
  • Tests included, if applicable
  • API docs and/or User Guide docs changed or added, if applicable

@CLAassistant
Copy link

CLAassistant commented May 14, 2023 •
edited

CLA assistant check
All committers have signed the CLA.

@Begasus Begasus mentioned this pull request May 14, 2023
Merged
@markusicu markusicu self-assigned this May 18, 2023
@markusicu markusicu requested a review from srl295 May 18, 2023 16:57
srl295
srl295 previously approved these changes May 19, 2023
View reviewed changes
Copy link
Member

@srl295 srl295 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems ok one question though.

icu4c/source/common/putilimp.h Outdated Show resolved Hide resolved
@jira-pull-request-webhook
Copy link

Notice: the branch changed across the force-push!

  • icu4c/source/common/putilimp.h is different

View Diff Across Force-Push

~ Your Friendly Jira-GitHub PR Checker Bot

@jira-pull-request-webhook
Copy link

Notice: the branch changed across the force-push!

  • icu4c/source/common/putilimp.h is different

View Diff Across Force-Push

~ Your Friendly Jira-GitHub PR Checker Bot

@jira-pull-request-webhook
Copy link

Hooray! The files in the branch are the same across the force-push. 😃

~ Your Friendly Jira-GitHub PR Checker Bot

@Begasus
Copy link
Author

Begasus commented Apr 29, 2024

Saw this was still open anything left to do?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@srl295 srl295 srl295 left review comments

At least 1 approving review is required to merge this pull request.

Assignees

@markusicu markusicu

Labels
None yet
Projects
None yet
Milestone
No milestone
4 participants
@Begasus @CLAassistant @srl295 @markusicu