ICU-22450 Disable the type_info workaround on newer versions of libstdc++ #2539
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
@glandium Can you sign CLA? Otherwise, we cannot look at your changes. |
|
I'm sorting this out through my employer. (an email has been sent to member-services at unicode.org about this. My work email is different than the one in the current commit, though, so I'll update that. |
…dc++ The workaround for http://llvm.org/bugs/show_bug.cgi?id=13364 is related to an ancient version of libstdc++ (4.6). On the flip side, with more recent versions of GCC, the workaround can cause problems under some conditions. The _GLIBCXX_RELEASE macro was introduced in libstdc++ 7, checking for it not being defined to enable the workaround makes it disabled with libstdc++ >= 7, which don't need the workaround in the first place.
|
Hooray! The files in the branch are the same across the force-push. 😃 ~ Your Friendly Jira-GitHub PR Checker Bot |
|
The CLA should be sorted out. |
|
Can this be merged? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The workaround for http://llvm.org/bugs/show_bug.cgi?id=13364 is related to an ancient version of libstdc++ (4.6). On the flip side, with more recent versions of GCC, the workaround can cause problems under some conditions.
The _GLIBCXX_RELEASE macro was introduced in libstdc++ 7, checking for it not being defined to enable the workaround makes it disabled with libstdc++ >= 7, which don't need the workaround in the first place.
Checklist