ICU-20250 faster MutableCodePointTrie.buildImmutable(): linear search -> hashtable #265
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aheninger
reviewed
Nov 5, 2018
aheninger
reviewed
Nov 7, 2018
icu4j/main/classes/core/src/com/ibm/icu/util/MutableCodePointTrie.java
Outdated
Show resolved
Hide resolved
icu4j/main/classes/core/src/com/ibm/icu/util/MutableCodePointTrie.java
Outdated
Show resolved
Hide resolved
|
I am not familiar with code base here, but the change LGTM. I see performance improvement 1,507ms -> 1,260ms on Android. Some other performance regression may come from Android itself. I will take a look. |
aheninger
previously approved these changes
Nov 7, 2018
…d equal blocks in earlier parts of the compacted data & index arrays
markusicu
force-pushed
the
triebuildhash
branch
from
bd32ddf
to
569e23d
Compare
aheninger
approved these changes
Nov 7, 2018
|
Just quick update. I think it fixes Android's regression issue. My previous comment was incorrect. I corrected my measurement, and I see DateTimePatternGenerator$FormatParser cinit performance improves by ~70%. It took ~217ms to cinit the class with ICU 63. It was ~400ms with ICU62. If I update the Android runtime with AOT compiled code, there will be another ~70- 75% performance improvement. |
mapx
pushed a commit
to mapx/icu
that referenced
this pull request
Dec 11, 2018
The start-up performance regression reported for Android WebView and Windows Chrome is traced to UnicodeSet creation for Unicode character properties. This upstream PR speeds up UnicodeSet creation. Upstream bug: https://unicode-org.atlassian.net/browse/ICU-20250 Upstream PR: unicode-org/icu#265 TBR=ftang@chromium.org Bug: 899983,901532 Test: Android webview start-up perf. Change-Id: Iffb6eac4ddde2cabd2f55fe718a9b4e3f39b4e05 Reviewed-on: https://chromium-review.googlesource.com/c/1325398 Reviewed-by: Jungshik Shin <jshin@chromium.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.