Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ICU-22764 Fix gendict memory safety in toml uchars mode #2988

Merged
merged 1 commit into from
May 3, 2024
Merged

ICU-22764 Fix gendict memory safety in toml uchars mode #2988

merged 1 commit into from
May 3, 2024

Conversation

sffc
Copy link
Member

@sffc sffc commented Apr 30, 2024 •
edited by markusicu
Loading

Checklist
  • Required: Issue filed: https://unicode-org.atlassian.net/browse/ICU-22764
  • Required: The PR title must be prefixed with a JIRA Issue number.
  • Required: The PR description must include the link to the Jira Issue, for example by completing the URL in the first checklist item
  • Required: Each commit message must be prefixed with a JIRA Issue number.
  • Issue accepted (done by Technical Committee after discussion)
  • Tests included, if applicable
  • API docs and/or User Guide docs changed or added, if applicable

@sffc sffc mentioned this pull request Apr 30, 2024
Merged
@sffc
Copy link
Member Author

sffc commented Apr 30, 2024

CC @Manishearth

@sffc sffc requested a review from srl295 April 30, 2024 21:10
@markusicu
Copy link
Member

@sffc ticket accepted

@sffc sffc merged commit 23bf38f into unicode-org:main May 3, 2024
97 checks passed
@sffc sffc deleted the ICU-22764-gendict branch May 3, 2024 18:02
@sffc sffc mentioned this pull request May 3, 2024
Merged
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Manishearth Manishearth Manishearth approved these changes

@markusicu markusicu markusicu approved these changes

@srl295 srl295 Awaiting requested review from srl295

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
3 participants
@sffc @markusicu @Manishearth