Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ICU-22813 Rise the size of the buffers used for the command strings at pkgdata #3058

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

ICU-22813 Rise the size of the buffers used for the command strings at pkgdata #3058

wants to merge 1 commit into from

Commits on Jul 1, 2024

  1. ICU-22813 Rise the size of the buffers used for the command strings a… 

    …t pkgdata

The tool pkgdata uses snprintf() to build the strings of the commands that
will execute later during the install process. But the maximum size of this
buffers is not enough when there is a long path.

This has caused issues on some CI systems that use very long paths, causing
the install process to produce a wrong result.

The maximum path on Linux is 4096 (defined as PATH_MAX at <linux/limits.h>)
So the size of SMALL_BUFFER_MAX_SIZE should be 4096 to avoid errors related
to truncated paths.
    @clopez
    clopez committed Jul 1, 2024
    Configuration menu
    Copy the full SHA
    db70ada View commit details
    Browse the repository at this point in the history