Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ICU-20536 Japanese era Reiwa support in ICU 63 #608

Merged
merged 3 commits into from Apr 11, 2019

Conversation

jefgen
Copy link
Member

@jefgen jefgen commented Apr 9, 2019

This also includes updating the time zone data to tzdata2019a.

Checklist

ALLOW_MANY_COMMITS=true

@jefgen jefgen requested review from yumaoka and daniel-ju April 9, 2019 00:09
@jefgen
Copy link
Member Author

jefgen commented Apr 11, 2019

Note: The failing CI tests all look to be expected.

ICU4C:

-------------
| ***     FAILING TEST SUMMARY FOR:              intltest  
         TestConsistentPivot
      DataDrivenFormatTest
   format
| *** END FAILING TEST SUMMARY FOR:              intltest
---------------
ALL TESTS SUMMARY:
ok:  testdata iotest cintltst
===== ERRS:  intltest

ICU4J:

	FAILED
[TestConsistentPivot#6format] FAIL: got Heisei 8 expected Reiwa 8
junit.framework.AssertionFailedError: [TestConsistentPivot#6format] FAIL: got Heisei 8 expected Reiwa 8

@jira-pull-request-webhook
Copy link

Notice: the branch changed across the force-push!

  • icu4c/source/test/testdata/format.txt is different
  • icu4j/main/shared/data/icudata.jar is different
  • icu4j/main/shared/data/icutzdata.jar is different
  • icu4j/main/shared/data/testdata.jar is different

View Diff Across Force-Push

~ Your Friendly Jira-GitHub PR Checker Bot

@jefgen
Copy link
Member Author

jefgen commented Apr 11, 2019

Note: Per discussion with Yoshito, the plan is to comment out the data-driven test cases that are conditional on the current system time so that the builds and tests pass regardless of the system time.

@jefgen jefgen requested a review from srl295 April 11, 2019 18:24
@jefgen jefgen merged commit 4f715ae into unicode-org:maint/maint-63 Apr 11, 2019
@jefgen jefgen deleted the jefgen/jaera-icu63 branch April 11, 2019 19:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants