Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ICU-20593 Various updates to resource tracing. #690

Merged
merged 1 commit into from Jul 9, 2019
Merged

ICU-20593 Various updates to resource tracing. #690

merged 1 commit into from Jul 9, 2019

Conversation

sffc
Copy link
Member

@sffc sffc commented Jun 18, 2019

Checklist

@sffc sffc requested a review from srl295 June 18, 2019 20:38
@jira-pull-request-webhook
Copy link

Hooray! The files in the branch are the same across the force-push. 😃

~ Your Friendly Jira-GitHub PR Checker Bot

@jira-pull-request-webhook
Copy link

Notice: the branch changed across the force-push!

  • icu4c/source/common/restrace.h is different
  • icu4c/source/common/uresbund.cpp is different

View Diff Across Force-Push

~ Your Friendly Jira-GitHub PR Checker Bot

@sffc
Copy link
Member Author

sffc commented Jun 19, 2019

^ Rebasing to master and then amending to fix test failures.

@sffc sffc requested review from markusicu and removed request for srl295 July 5, 2019 16:51
@sffc sffc assigned markusicu and unassigned srl295 Jul 5, 2019
markusicu
markusicu reviewed Jul 5, 2019
View reviewed changes
docs/userguide/icu_data/tracing.md Outdated Show resolved Hide resolved
icu4c/source/common/restrace.cpp Outdated Show resolved Hide resolved
icu4c/source/common/restrace.cpp Outdated Show resolved Hide resolved
icu4c/source/common/restrace.h Outdated Show resolved Hide resolved
icu4c/source/common/uresbund.cpp Outdated Show resolved Hide resolved
icu4c/source/test/intltest/restsnew.cpp Outdated Show resolved Hide resolved
@jira-pull-request-webhook
Copy link

Notice: the branch changed across the force-push!

  • docs/userguide/icu_data/tracing.md is different
  • icu4c/source/common/restrace.cpp is different
  • icu4c/source/common/restrace.h is different
  • icu4c/source/common/uresbund.cpp is different
  • icu4c/source/test/intltest/restsnew.cpp is different

View Diff Across Force-Push

~ Your Friendly Jira-GitHub PR Checker Bot

@sffc sffc requested a review from markusicu July 8, 2019 21:34
@jira-pull-request-webhook
Copy link

Notice: the branch changed across the force-push!

  • icu4c/source/common/restrace.cpp is different
  • icu4c/source/common/restrace.h is different

View Diff Across Force-Push

~ Your Friendly Jira-GitHub PR Checker Bot

@sffc sffc requested a review from markusicu July 8, 2019 23:58
markusicu
markusicu approved these changes Jul 9, 2019
View reviewed changes
Copy link
Member

@markusicu markusicu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@sffc sffc merged commit 77ca774 into unicode-org:master Jul 9, 2019
@sffc sffc deleted the ICU-20593-btrace branch July 9, 2019 20:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@markusicu markusicu markusicu approved these changes

Assignees

@markusicu markusicu

Labels
None yet
Projects
None yet
Milestone
No milestone
3 participants
@sffc @markusicu @srl295