ICU-20310 omit "-true" in toLanguageTag #952
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
roubert
reviewed
Dec 20, 2019
| @@ -3257,6 +3257,11 @@ public String toLanguageTag() { | |||
| subtags = tag.getExtensions(); | |||
| for (String s : subtags) { | |||
| buf.append(LanguageTag.SEP); | |||
| if (s.endsWith("-true")) { | |||
There was a problem hiding this comment.
Would it not be more logical to do this inside of LanguageTag.canonicalizeExtension() instead?
roubert
previously approved these changes
Dec 20, 2019
FrankYFTang
force-pushed
the
ICU-20310-true
branch
from
b607e5e
to
34931b5
Compare
|
Hooray! The files in the branch are the same across the force-push. 😃 ~ Your Friendly Jira-GitHub PR Checker Bot |
roubert
approved these changes
Dec 27, 2019
manuelpuyol
added a commit
to manuelpuyol/hermes
that referenced
this pull request
Mar 21, 2024
Versions before 67 had a bug with defaults, where they were adding the `yes` and `true` defaults to Language Tags. See unicode-org/icu#952 for their fix.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist