Skip to content

Commit

Permalink
Merge CLDR, UProps, and Segmenter providers into icu_datagen (#1740)
Browse files Browse the repository at this point in the history
  • Loading branch information
sffc committed Mar 27, 2022
1 parent 7eeafcc commit 4c700aa
Show file tree
Hide file tree
Showing 84 changed files with 226 additions and 1,494 deletions.
2 changes: 1 addition & 1 deletion .gitignore
Original file line number Diff line number Diff line change
Expand Up @@ -22,9 +22,9 @@ dhat-heap.json
/benchmarks

# Do not check-in binary file tree test data
provider/datagen/tests/testdata/work_log_bincode
provider/testdata/data/bincode
provider/testdata/data/postcard
tools/datagen/tests/testdata/work_log_bincode

# Ignore irrelevant files that get generated on macOS
**/.DS_Store
Expand Down
4 changes: 1 addition & 3 deletions CODEOWNERS
Validating CODEOWNERS rules …
Original file line number Diff line number Diff line change
Expand Up @@ -26,16 +26,14 @@ ffi/cpp/ @Manishearth
ffi/ecma402/ @filmil
ffi/wasm/ @Manishearth
provider/blob/ @sffc @Manishearth
provider/cldr/ @sffc @nordzilla
provider/core/ @sffc @Manishearth
provider/datagen/ @sffc @robertbastian @Manishearth
provider/fs/ @sffc
provider/macros/ @Manishearth @sffc
provider/testdata/ @unicode-org/icu4x-owners
provider/segmenter/ @aethanyc @makotokato
tools/benchmark/binsize/ @gnrunge
tools/benchmark/macros/ @gregtatum
tools/benchmark/memory/ @gregtatum
tools/datagen/ @sffc
tools/scripts/ @Manishearth @sffc
utils/fixed_decimal/ @sffc
utils/litemap/ @Manishearth @sffc
Expand Down
116 changes: 32 additions & 84 deletions Cargo.lock

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

5 changes: 1 addition & 4 deletions Cargo.toml
Original file line number Diff line number Diff line change
Expand Up @@ -27,17 +27,14 @@ members = [
"ffi/ecma402",
"provider/adapters",
"provider/blob",
"provider/cldr",
"provider/core",
"provider/datagen",
"provider/fs",
"provider/macros",
"provider/segmenter",
"provider/testdata",
"provider/uprops",
"tools/benchmark/macros",
"tools/benchmark/memory",
"tools/benchmark/binsize",
"tools/datagen",
"utils/codepointtrie",
"utils/deduplicating_array",
"utils/fixed_decimal",
Expand Down
10 changes: 5 additions & 5 deletions docs/tutorials/writing_a_new_data_struct.md
Original file line number Diff line number Diff line change
Expand Up @@ -55,11 +55,11 @@ Although they may share common code, source data providers are implemented speci

Examples of source data providers include:

- [`CldrJsonDataProvider`](https://unicode-org.github.io/icu4x-docs/doc/icu_provider_cldr/transform/struct.CldrJsonDataProvider.html#)
- [`NumbersProvider`](https://unicode-org.github.io/icu4x-docs/doc/icu_provider_cldr/transform/struct.NumbersProvider.html)
- [`PluralsProvider`](https://unicode-org.github.io/icu4x-docs/doc/icu_provider_cldr/transform/struct.PluralsProvider.html)
- [`DateSymbolsProvider`](https://unicode-org.github.io/icu4x-docs/doc/icu_provider_cldr/transform/struct.DateSymbolsProvider.html)
- [… more examples](https://unicode-org.github.io/icu4x-docs/doc/icu_provider_cldr/transform/index.html)
- [`CldrJsonDataProvider`](https://unicode-org.github.io/icu4x-docs/doc/icu_datagen/cldr/transform/struct.CldrJsonDataProvider.html#)
- [`NumbersProvider`](https://unicode-org.github.io/icu4x-docs/doc/icu_datagen/cldr/transform/struct.NumbersProvider.html)
- [`PluralsProvider`](https://unicode-org.github.io/icu4x-docs/doc/icu_datagen/cldr/transform/struct.PluralsProvider.html)
- [`DateSymbolsProvider`](https://unicode-org.github.io/icu4x-docs/doc/icu_datagen/cldr/transform/struct.DateSymbolsProvider.html)
- [… more examples](https://unicode-org.github.io/icu4x-docs/doc/icu_datagen/cldr/transform/index.html)
- `BinaryPropertyUnicodeSetDataProvider`
- [`HelloWorldProvider`](https://unicode-org.github.io/icu4x-docs/doc/icu_provider/hello_world/struct.HelloWorldProvider.html)

Expand Down
2 changes: 1 addition & 1 deletion provider/blob/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,7 @@ For more examples, see the specific data providers.

[`ICU4X`]: ../icu/index.html
[`BufferProvider`]: icu_provider::BufferProvider
[`icu4x-datagen`]: https://github.com/unicode-org/icu4x/tree/main/tools/datagen#readme
[`icu4x-datagen`]: https://github.com/unicode-org/icu4x/tree/main/provider/datagen#readme

## More Information

Expand Down
2 changes: 1 addition & 1 deletion provider/blob/src/lib.rs
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,7 @@
//!
//! [`ICU4X`]: ../icu/index.html
//! [`BufferProvider`]: icu_provider::BufferProvider
//! [`icu4x-datagen`]: https://github.com/unicode-org/icu4x/tree/main/tools/datagen#readme
//! [`icu4x-datagen`]: https://github.com/unicode-org/icu4x/tree/main/provider/datagen#readme

// https://github.com/unicode-org/icu4x/blob/main/docs/process/boilerplate.md#library-annotations
#![cfg_attr(not(any(test, feature = "std")), no_std)]
Expand Down
22 changes: 0 additions & 22 deletions provider/cldr/README.md

This file was deleted.

2 changes: 1 addition & 1 deletion provider/core/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -111,7 +111,7 @@ This trait is normally implemented using the [`impl_dyn_provider!`] macro using
[`icu_provider_adapters`]: ../icu_provider_adapters/index.html
[`as_downcasting()`]: AsDowncastingAnyProvider::as_downcasting
[`as_deserializing()`]: AsDeserializingBufferProvider::as_deserializing
[`CldrJsonDataProvider`]: ../icu_provider_cldr/struct.CldrJsonDataProvider.html
[`CldrJsonDataProvider`]: ../icu_datagen/cldr/struct.CldrJsonDataProvider.html
[`FsDataProvider`]: ../icu_provider_fs/struct.FsDataProvider.html
[`BlobDataProvider`]: ../icu_provider_blob/struct.BlobDataProvider.html

Expand Down
2 changes: 1 addition & 1 deletion provider/core/src/lib.rs
Original file line number Diff line number Diff line change
Expand Up @@ -113,7 +113,7 @@
//! [`icu_provider_adapters`]: ../icu_provider_adapters/index.html
//! [`as_downcasting()`]: AsDowncastingAnyProvider::as_downcasting
//! [`as_deserializing()`]: AsDeserializingBufferProvider::as_deserializing
//! [`CldrJsonDataProvider`]: ../icu_provider_cldr/struct.CldrJsonDataProvider.html
//! [`CldrJsonDataProvider`]: ../icu_datagen/cldr/struct.CldrJsonDataProvider.html
//! [`FsDataProvider`]: ../icu_provider_fs/struct.FsDataProvider.html
//! [`BlobDataProvider`]: ../icu_provider_blob/struct.BlobDataProvider.html

Expand Down
Loading

0 comments on commit 4c700aa

Please sign in to comment.