Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move zerovec to no_std #1094

Merged
merged 6 commits into from Sep 23, 2021
Merged

Move zerovec to no_std #1094

merged 6 commits into from Sep 23, 2021

Conversation

Manishearth
Copy link
Member

Turns out we never did this. Oops.

Unblocks #922 CI

@Manishearth Manishearth mentioned this pull request Sep 23, 2021
Closed
29 tasks
sffc
sffc previously approved these changes Sep 23, 2021
View reviewed changes
Copy link
Member

@sffc sffc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some odd changes to spacing after the currency headers, but LGTM

@Manishearth
Copy link
Member Author

Yeah I forgot to apply rustfmt :)

echeran
echeran approved these changes Sep 23, 2021
View reviewed changes
Copy link
Contributor

@echeran echeran left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Manishearth Manishearth merged commit d821987 into unicode-org:main Sep 23, 2021
@Manishearth Manishearth deleted the nostd-zv branch September 23, 2021 21:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@echeran echeran echeran approved these changes

@sffc sffc sffc left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Manishearth @echeran @sffc