Update tracking bug for removal of YokeTraitHack #1134
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Manishearth
requested changes
Oct 1, 2021
utils/yoke/src/trait_hack.rs
Outdated
| //! ***[#1061](https://github.com/unicode-org/icu4x/issues/1061): The following example | ||
| //! compiles starting in Rust 1.56. | ||
| //! ```compile_fail | ||
| //! trait MiniYokeable<'a> { |
There was a problem hiding this comment.
Let's not check in MiniYoke stuff: can we get the version of this that uses actual Yoke?
There was a problem hiding this comment.
I was afraid you'd ask that... I copied my minified example into here because it serves the purpose of the compile_fail. But I'll try to un-minify it...
There was a problem hiding this comment.
Yeah I'd like this to show off the kind of code that will actually break in ICU4X :)
There was a problem hiding this comment.
ok so note that this is in the yoke crate, not the icu_provider crate. So I updated the example to use the real Yoke/Yokeable but MiniDataProvider. Is that ok or do you want me to add the dev dependency, or move this to the other crate?
Manishearth
approved these changes
Oct 1, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replaces #1090