Simplify Language representation #1695
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Manishearth
previously approved these changes
Mar 15, 2022
zbraniecki
previously approved these changes
Mar 15, 2022
|
|
||
| const LANGUAGE_LENGTH: RangeInclusive<usize> = 2..=3; | ||
| const UND_VALUE: TinyAsciiStr<3> = tinystr!(3, "und"); | ||
| // Safe because "und" is a valid language subtag | ||
| const UND: Language = Language(unsafe { TinyAsciiStr::from_bytes_unchecked(*b"und") }); |
There was a problem hiding this comment.
This could be lang!("und") after #1631 . @zbraniecki please take a look at that.
There was a problem hiding this comment.
I'll add a TODO(#348) here, and you can fix it in your PR (which it looks like you need to rebase anyway).
|
Hooray! The files in the branch are the same across the force-push. 😃 ~ Your Friendly Jira-GitHub PR Checker Bot |
|
^ rebasing onto main. |
Manishearth
previously approved these changes
Mar 16, 2022
Manishearth
approved these changes
Mar 16, 2022
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR changes
Languagefrom wrappingOption<TinyAsciiStr>to justTinyAsciiStr, with theNonevariant encoded as a literaltinystr!("und").There are two reasons for this change:
Languageto be its own ULE.Please let me know which benches you'd like me to run if you would like to see benchmark results.