Moving source data out of icu_testdata
#3044
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
robertbastian
requested review from
Manishearth,
sffc,
a team,
zbraniecki and
nciric
as code owners
robertbastian
force-pushed
the
datastuff
branch
from
35f0642
to
f07993a
Compare
This comment was marked as spam.
This comment was marked as spam.
sffc
reviewed
Jan 30, 2023
robertbastian
requested review from
sffc
and removed request for
zbraniecki and
nciric
sffc
reviewed
Jan 31, 2023
|
🎉 All dependencies have been resolved ! |
sffc
reviewed
Feb 1, 2023
sffc
reviewed
Feb 3, 2023
sffc
reviewed
Feb 3, 2023
sffc
reviewed
Feb 14, 2023
sffc
reviewed
Feb 14, 2023
sffc
reviewed
Feb 14, 2023
sffc
reviewed
Feb 21, 2023
| @@ -0,0 +1,27 @@ | |||
| // This file is part of ICU4X. For terms of use, please see the file | |||
There was a problem hiding this comment.
Nit: Please update .gitattributes with the new paths for generated data files
sffc
reviewed
Feb 21, 2023
.gitattributes
Outdated
| provider/testdata/data/json/** linguist-generated=true | ||
| provider/testdata/data/cldr/** linguist-generated=true | ||
| provider/testdata/data/icuexport/** linguist-generated=true | ||
| provider/testdata/data/** linguist-generated=true |
There was a problem hiding this comment.
Issue: We had these pointing at subdirectories because there are certain files we don't want to hide away, like the fingerprint files
There was a problem hiding this comment.
They are generated though
There was a problem hiding this comment.
Sure, but the reason we use this feature is to control GitHub reviews, and it's important that fingerprint files are part of reviews. We had this discussion when we first added the linguist-generated attributes.
sffc
approved these changes
Feb 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
provider/testdata/data/{cldr,icuexport}toprovider/repodata/datatools/testdata-scripts/locales.rs.dataSourceData::{LATEST_TESTED_CLDR_TAG, LATEST_TESTED_ICUEXPORT_TAG}make-testdatageneratesprovider/testdata/data/metadata.rs.datafrom thesetestdata-scripts->icu_testdatadependency, and fixescargo quickyields compile errors #3013Depends on #3042
Part of #3038