Baked data for icu_segmenter
#3570
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
robertbastian
requested review from
Manishearth,
sffc,
aethanyc,
makotokato and
a team
as code owners
Manishearth
previously approved these changes
Jun 22, 2023
sffc
previously approved these changes
Jun 23, 2023
| + ?Sized, | ||
| { | ||
| Self::try_new_auto_with_options_unstable(provider, Default::default()) | ||
| pub fn new_auto() -> Self { |
There was a problem hiding this comment.
Question: why aren't you auto-generating the impls for the globaldata constructors in this crate?
There was a problem hiding this comment.
Auto generated constructors will go through DataProvider::load and be fallible. This uses singletons and is infallible.
robertbastian
force-pushed
the
segmenter
branch
2 times, most recently
from
1d41bba
to
d915061
Compare
sffc
approved these changes
Jun 26, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#2945