Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Returning correct locale errors in datagen #3578

Merged
merged 2 commits into from
Jun 24, 2023
Merged

Returning correct locale errors in datagen #3578

merged 2 commits into from
Jun 24, 2023

Conversation

robertbastian
Copy link
Member

@robertbastian robertbastian commented Jun 23, 2023 •
edited
Loading

sffc
sffc approved these changes Jun 23, 2023
View reviewed changes
provider/datagen/src/transform/mod.rs
metadata: Default::default()
}
)
.is_err());
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit (optional): assert the error kind

@robertbastian robertbastian merged commit 67ccd5e into unicode-org:main Jun 24, 2023
23 checks passed
@robertbastian robertbastian deleted the localeerrs branch June 24, 2023 10:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sffc sffc sffc approved these changes

@Manishearth Manishearth Manishearth approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@robertbastian @sffc @Manishearth