Add Ord on locale related structs #3588
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
Hi! Please take a look at #1215 |
|
Okay, cool. I half expected this might be the case but couldn’t find it. The problem is, it wasn’t resolved and instead simply removed. Lexicographical ordering of keys is sufficient, and adding subjective bias to what are ultimately string markers for a locale and its configuration is at the very least interesting but not particularly useful. What is the path forward? |
sffc
requested changes
Jun 28, 2023
|
That is a path forward. 🙂 |
|
Closing for now, but we're still open to an Ord impl in accordance with the issues above. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds
Ordto Locale related structs so aLocalecan be used as a key in aBTreeMap.